Skip to content

Conversation

@FaheemOnHub
Copy link
Contributor

This PR fixes https://github.com/layer5io/meshery-cloud/issues/3567

  • Yes, I signed my commits.

Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
@FaheemOnHub FaheemOnHub requested a review from zihanKuang June 4, 2025 16:40
@leecalcote
Copy link
Member

@aabidsofi19 will you put eyes on this, pretty please?

@aabidsofi19
Copy link
Contributor

@FaheemOnHub why are we removing user.id it should works also for identifying or filtering out users

@aabidsofi19
Copy link
Contributor

It might be that we are doing something silly with users api response in meshery cloud UI ( may transforming )

@leecalcote
Copy link
Member

@FaheemOnHub what are your thoughts on this one?

@FaheemOnHub
Copy link
Contributor Author

@FaheemOnHub why are we removing user.id it should works also for identifying or filtering out users

We are not removing user.id , we are adding user.id
basically we were using .id to search , which does not exist in usersData (was wrong)
Screenshot 2025-06-19 at 8 54 23 PM

so because of that it was taking all users as one , and when one was added , it shows(no user found).

@FaheemOnHub FaheemOnHub requested a review from leecalcote June 19, 2025 15:31
@FaheemOnHub
Copy link
Contributor Author

we can merge this!!!

@FaheemOnHub FaheemOnHub requested a review from amitamrutiya June 24, 2025 18:45
@FaheemOnHub
Copy link
Contributor Author

@leecalcote leecalcote merged commit 77983b2 into layer5io:master Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants