-
Notifications
You must be signed in to change notification settings - Fork 9.4k
magento/magento2#39729: Cannot return null for non-nullable field "SelectedCustomizableOption.label" #39888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
magento/magento2#39729: Cannot return null for non-nullable field "SelectedCustomizableOption.label" #39888
Conversation
…tomizableOption.label"
Hi @KrasnoshchokBohdan. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @KrasnoshchokBohdan,
Thanks for the contribution!
The code changes seems good to us, but please add some automated test in accordance to the DOD.
Thanks
Description (*)
Skip any deleted/invalid custom options instead of including them in the result
\Magento\QuoteGraphQl\Model\Resolver\CustomizableOptions::resolve
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)