-
Notifications
You must be signed in to change notification settings - Fork 633
fix(streamble_http) SendNotification not work bug #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(streamble_http) SendNotification not work bug #473
Conversation
""" WalkthroughThis change updates the HTTP status code in the Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. could you please replace http.StatusAccepted
with http.StatusOK
?
Description
Fixes #334
The Reason that MCP Inspector and Python-SDK client can't receive sse stream is that the client will ignore the meesage when Status == 202.
According to https://modelcontextprotocol.io/specification/2025-06-18/basic/transports#sending-messages-to-the-server, the 5th and 6th is the spec of handle the input of JSON-RPC request, there no mention that we need to add StatusCode=202 to the response header.
After remove it, MCP Inspector can receive progress notifications as expected.
Type of Change
Checklist
Summary by CodeRabbit