-
-
Notifications
You must be signed in to change notification settings - Fork 34
fix: false postive report of no-unused-expressions
#584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses false positive reports of the no-unused-expressions lint rule by adding a new MDX test fixture and updating snapshot files to capture the reported errors.
- Adds the fixture test/fixtures/581.mdx with code to trigger the false positive
- Updates the snapshot test file (test/snapshots/fixtures.test.ts.snap) with expected linter error outputs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
test/fixtures/581.mdx | New fixture file demonstrating usage of expressions with lodash and exported objects |
test/snapshots/fixtures.test.ts.snap | Snapshot update capturing the expected false positive lint error details |
Comments suppressed due to low confidence (1)
test/snapshots/fixtures.test.ts.snap:1229
- The snapshot displays duplicate lint error entries related to the 'no-unused-expressions' rule. If these duplicates are not intentional, consider reviewing the lint configuration to consolidate or suppress duplicate reports.
exports[`fixtures should match all snapshots: 581.mdx 1`] = `
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 274 274
Branches 47 47
=========================================
Hits 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
no-unused-expressions
no-unused-expressions
Initial checklist
Description of changes
fix #581