Remove networkx stubs in favor of typeshed #369
Draft
+12
−7,520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this will resolve my issue here with deprecated signatures
But Pylance shows me an error with its built in stubs in 2025.5.1 |
…into remove-networkx
|
I think once python/typeshed#14256 is merged, I'll feel comfortable enough removing networkx from microsoft/python-type-stubs. There would still be lots of param types missing from typeshed (done in python/typeshed#14038), but these here stubs are full of incorrect or overly restrictive annotations anyway, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkx stubs have been added to typeshed in python/typeshed#10544 almost two years ago.
Many improvements since then.
In python/typeshed#14038 I'm currently merging what's left of these stubs that isn't present in typeshed to ensure no false-positive regressions to Pylance users. (and to not loose any work done here)
I already added all missing symbols in python/typeshed#14084
In python/typeshed#14256 I added all return type stubs