Skip to content

v8: fix missing callback in heap utils destroy #58846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BridgeAR
Copy link
Member

This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place.

Thanks to @ronag to look into this!

This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 26, 2025
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix lint issue and this is good to go 👍

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (d6dade5) to head (df175e2).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58846      +/-   ##
==========================================
- Coverage   90.12%   90.10%   -0.03%     
==========================================
  Files         637      640       +3     
  Lines      188121   188447     +326     
  Branches    36892    36967      +75     
==========================================
+ Hits       169552   169800     +248     
- Misses      11313    11348      +35     
- Partials     7256     7299      +43     
Files with missing lines Coverage Δ
lib/internal/heap_utils.js 100.00% <100.00%> (ø)

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added request-ci Add this label to start a Jenkins CI on a PR. v8 module Issues and PRs related to the "v8" subsystem. labels Jun 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants