-
-
Notifications
You must be signed in to change notification settings - Fork 32k
v8: fix missing callback in heap utils destroy #58846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BridgeAR
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
BridgeAR:2025-06-26-fix-mussing-destroy-callback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
v8: fix missing callback in heap utils destroy #58846
BridgeAR
wants to merge
2
commits into
nodejs:main
from
BridgeAR:2025-06-26-fix-mussing-destroy-callback
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place.
Ethan-Arrowood
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fix lint issue and this is good to go 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58846 +/- ##
==========================================
- Coverage 90.12% 90.10% -0.03%
==========================================
Files 637 640 +3
Lines 188121 188447 +326
Branches 36892 36967 +75
==========================================
+ Hits 169552 169800 +248
- Misses 11313 11348 +35
- Partials 7256 7299 +43
🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Jun 26, 2025
lpinca
approved these changes
Jun 26, 2025
legendecas
approved these changes
Jun 27, 2025
codebytere
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place.
Thanks to @ronag to look into this!