Skip to content

fs: close dir before throwing if options.bufferSize is invalid #58856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Jun 26, 2025

Fixes: #58854

Test blocked on: #58855

@LiviaMedeiros LiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Jun 26, 2025
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (4d5ee24) to head (eadbae5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58856      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.01%     
==========================================
  Files         640      640              
  Lines      188493   188499       +6     
  Branches    36971    36968       -3     
==========================================
+ Hits       169843   169848       +5     
- Misses      11358    11361       +3     
+ Partials     7292     7290       -2     
Files with missing lines Coverage Δ
lib/internal/fs/dir.js 94.57% <100.00%> (+0.08%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros force-pushed the fs-dir-close-on-invalid-buffer branch from 2155c48 to 67ea569 Compare June 29, 2025 05:53
@LiviaMedeiros LiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Jun 29, 2025
@LiviaMedeiros LiviaMedeiros force-pushed the fs-dir-close-on-invalid-buffer branch from 67ea569 to eadbae5 Compare June 29, 2025 05:57
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs: opendirSync() leaks directory handle on error
2 participants