Skip to content

build: disable v8_enable_pointer_compression_shared_cage on non-64bit #58867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

build: disable v8_enable_pointer_compression_shared_cage on non-64bit #58867

merged 1 commit into from
Jun 30, 2025
+1 −0

Conversation

codebytere
Copy link
Member

Refs #58171

Ensure v8_enable_pointer_compression_shared_cage is also disabled on non-64-bit architectures, as V8 pointer compression only supports 64bit architectures.

@codebytere codebytere requested review from zcbenz and joyeecheung June 27, 2025 17:43
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 27, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67687/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67692/

@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Jun 28, 2025
@codebytere codebytere mentioned this pull request Jun 28, 2025
Merged
@codebytere codebytere added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 30, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit ab9ef37 into nodejs:main Jun 30, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ab9ef37

targos pushed a commit that referenced this pull request Jul 3, 2025
@codebytere @targos
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
c76585d 
PR-URL: #58867
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @richardlau @RafaelGSS