Skip to content

dxf: get task from both mysql.tidb_global_task and mysql.tidb_global_task_history (#57063) #62049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57063

What problem does this PR solve?

Issue Number: close #56942

Problem Summary:
#56942 (comment)

What changed and how does it work?

Get the task from mysql.tidb_global_task and mysql.tidb_global_task_history in updateDistTaskRowCount, and sum up the row count from both tidb_background_subtask and tidb_background_subtask_history table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Use sysbench create 100 tables with 10000 rows each.
  2. After all ddl jobs finished, check the ddl job row count, the row_count should all be 10000:
mysql> admin show ddl jobs 100 where row_count != 10000;
Empty set (0.03 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 27, 2025
@ti-chi-bot
Copy link
Member Author

@fzzf678 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 2, 2025
@fzzf678
Copy link
Contributor

fzzf678 commented Jul 2, 2025

/retest

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@61d7f3c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #62049   +/-   ##
================================================
  Coverage               ?   71.2847%           
================================================
  Files                  ?       1468           
  Lines                  ?     424405           
  Branches               ?          0           
================================================
  Hits                   ?     302536           
  Misses                 ?     101350           
  Partials               ?      20519           
Flag Coverage Δ
unit 71.2847% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4147% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 2, 2025
Copy link

ti-chi-bot bot commented Jul 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-02 01:47:33.535493116 +0000 UTC m=+1445906.258672098: ☑️ agreed by fzzf678.
  • 2025-07-02 02:43:22.301374385 +0000 UTC m=+1449255.024553367: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 2, 2025
@fzzf678
Copy link
Contributor

fzzf678 commented Jul 3, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
Copy link

ti-chi-bot bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit d68dd3c into pingcap:release-8.1 Jul 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants