refactor: update DMR version display logic in VersionSelect component

[shhdgit]

• Modified the rendering of DMR versions to only display when available, improving clarity and user experience.
• Wrapped DMR version items in a fragment for better structure and readability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
website-docs	❌ Failed (Inspect)			Jul 3, 2025 9:13am

[gemini-code-assist]

Summary of Changes

Hello @shhdgit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the VersionSelect component by implementing more robust conditional rendering for DMR versions and improving the structural grouping of related UI elements. The changes aim to enhance user experience by only displaying relevant sections and to improve code maintainability through cleaner component composition.

Highlights

• Conditional Rendering: The display of the 'DMR' section and its associated version items in the VersionSelect component is now conditional. It will only render if pathConfig.repo is 'tidb' AND the DMRVersions array contains at least one item. This prevents an empty 'DMR' label from appearing when no DMR versions are available.
• Code Structure and Readability: The 'DMR' FormLabel and the subsequent mapped MenuItem components are now wrapped within a React Fragment (<>...</>). This groups these related UI elements logically without introducing an unnecessary wrapper DOM node, improving the component's structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the VersionSelect component to improve the display logic for DMR versions, ensuring they are only rendered when available. A suggestion has been made to add a null check within the DMRVersions.map function to enhance the robustness of the component.

[gemini-code-assist]

Consider adding a check for null or undefined versions within the DMRVersions.map function to prevent potential issues with generating malformed URLs or unexpected behavior. This will ensure that only valid versions are rendered as menu items.

{DMRVersions.map((version) => {
            if (!version) {
              return null;
            }
            return (
              <MenuItem
                key={`menu-${version}`}
                value={`menu-${version}`}
                disabled={!availIn.includes(version)}
                component={LinkComponent}
                isI18n
                to={`/${pathConfig.repo}/${version}/${name}`}
              >
                <Typography
                  component="div"
                  sx={{
                    fontSize: "0.875rem",
                    lineHeight: "1.25rem",
                  }}
                >
                  {renderVersion(version, pathConfig)}
                </Typography>
              </MenuItem>
            );
          })}