Skip to content

[Terraform Plugin] Plan stage #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 4, 2025

What this PR does:

Why we need it:

To support TERRAFORM_PLAN stage.

Which issue(s) this PR fixes:

Part of #5992

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 4 commits July 4, 2025 17:00
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner July 4, 2025 09:12
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 30.26634% with 288 lines in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (da6fce4) to head (0363eff).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/terraform/provider/terraform.go 30.62% 177 Missing and 11 partials ⚠️
.../pipedv1/plugin/terraform/deployment/initialize.go 10.52% 51 Missing ⚠️
...kg/app/pipedv1/plugin/terraform/deployment/plan.go 0.00% 25 Missing ⚠️
...kg/app/pipedv1/plugin/terraform/provider/module.go 72.00% 9 Missing and 5 partials ⚠️
.../app/pipedv1/plugin/terraform/deployment/plugin.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6006      +/-   ##
==========================================
+ Coverage   28.16%   28.30%   +0.13%     
==========================================
  Files         519      527       +8     
  Lines       55938    56542     +604     
==========================================
+ Hits        15757    16004     +247     
- Misses      38931    39271     +340     
- Partials     1250     1267      +17     
Flag Coverage Δ
. 23.27% <ø> (+0.04%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 65.94% <ø> (-0.33%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 66.66% <ø> (?)
.-pkg-app-pipedv1-plugin-terraform 38.11% <30.26%> (-42.15%) ⬇️
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (-0.22%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

t-kikuc added 3 commits July 4, 2025 18:27
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc mentioned this pull request Jul 4, 2025
6 tasks
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

t-kikuc added 2 commits July 18, 2025 16:29
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc enabled auto-merge (squash) July 18, 2025 07:32
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants