-
Notifications
You must be signed in to change notification settings - Fork 187
[Terraform Plugin] Plan stage #6006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6006 +/- ##
==========================================
+ Coverage 28.16% 28.30% +0.13%
==========================================
Files 519 527 +8
Lines 55938 56542 +604
==========================================
+ Hits 15757 16004 +247
- Misses 38931 39271 +340
- Partials 1250 1267 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
What this PR does:
terraform/provider
from platformprovider/terraforminitialize.go
andplan.go
based on piepdv0executor
(https://github.com/pipe-cd/pipecd/tree/master/pkg/app/piped/executor/terraform)Why we need it:
To support TERRAFORM_PLAN stage.
Which issue(s) this PR fixes:
Part of #5992
Does this PR introduce a user-facing change?: