Skip to content

GSoC '25 Community Bonding and First Week report by Krish #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

MostlyKIGuess
Copy link
Member

Description

Week 1 updates.

Checklist

Checked on browser, seem to work!

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

@MostlyKIGuess
Copy link
Member Author

Sorry if I went a little overboard writing, it was fun!

Comment on lines +46 to +49
sudo rm -rf /usr/lib/python3.13/site-packages/sugar3;sudo cp -r ./src/sugar3 /usr/lib/python3.13/site-packages/sugar3

# Complete rebuild and install cycle
sudo ./autogen.sh;sudo make clean;sudo make;sudo make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copying is usually done after the build, I'm wondering why you're doing it before in this case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just 2 seperate shell commands, I am just mentioning that I clubbed them

Copy link
Member

@chimosky chimosky Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that they're different commands, there's no mention of you clubbing them — what does clubbing mean?.

I'm fine with your blog report detailing your workflow, we won't need to change any of our docs to fit this when the time comes so it's cool.

Copy link

@quozl quozl Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When chaining commands like this, it can be better to make a compound command linked by && than using ;, e.g. make && make install

That way when one of them fails, the others are not run.

Alternatively, place at the start of your script #!/bin/bash -e and don't use source or . to run it, but chmod +x and execute it directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right that gave me an idea to add a binding on these and I can add a shell script.

Thank you!! I will add this on the blogs by next week

@chimosky
Copy link
Member

chimosky commented Jun 7, 2025

@pikurasa kindly review.

Comment on lines +85 to +90
```c
typedef struct {
double x;
double y;
} SugarPoint;
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this appear as expected when rendered?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really but it' okay :p

@pikurasa pikurasa merged commit 7881d5f into sugarlabs:main Jun 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants