Elwin Li - Week 1 GSoC report for JSeditor updates #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em solve, not just learning to program
sa-fw-an
reviewed
Jun 8, 2025
Comment on lines
+36
to
+68
| { | ||
| "name": "repeat", | ||
| "comments": "Repeat block in the Flow palette", | ||
| "arguments": [ | ||
| { | ||
| "type": "NumberExpression" | ||
| } | ||
| ], | ||
| "ast": { | ||
| "identifiers": [ | ||
| { | ||
| "property": "type", | ||
| "value": "ForStatement" | ||
| } | ||
| ], | ||
| "argument_properties": [ | ||
| "test.right" | ||
| ], | ||
| "children_properties": [ | ||
| "body.body" | ||
| ] | ||
| }, | ||
| "blocklist_connections": [ | ||
| "parent_or_previous_sibling", | ||
| "argument", | ||
| "first_child", | ||
| "next_sibling" | ||
| ], | ||
| "default_vspaces": { | ||
| "argument": 1 | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this code block appear visually as written in the md file?
|
You should do these in a branch other than your main branch. Not doing so could cause major headaches if we don't merge some of your code. |
|
@ebeetles as to not roadblock this, I'm merging now, but please get in the habit of creating new branches for your PRs. |
Got it, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Submit changes to the project for review and inclusion
Description
Elwin Li - Week 1 GSoC report for JSeditor updates
Checklist
Additional Notes for Reviewers
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.