Skip to content

Update pr-x86.yml with 2025.2 package versions #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

Update pr-x86.yml with 2025.2 package versions #696

merged 3 commits into from
Jul 3, 2025

Conversation

itopinsk
Copy link
Contributor

@itopinsk itopinsk commented Jul 1, 2025 •
edited
Loading

Description

PR updates Intel oneMKL/Compiler versions to 2025.2 in CI workflow and updates MKLConfigVersion.cmake with 2025.2 version for Intel oneMKL.

All Submissions

  • Do all unit tests pass locally? Attach a log.

@itopinsk itopinsk requested a review from a team as a code owner July 1, 2025 09:51
@itopinsk itopinsk added this to the v0.8 milestone Jul 1, 2025
@andrewtbarker
Copy link
Contributor

andrewtbarker commented Jul 1, 2025 •
edited
Loading

@EwanC Do you have any idea why the GraphGemm tests are failing here?

The following tests FAILED:
	981 - BLAS/RT/GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________ (Failed)
	1965 - BLAS/CT/GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________ (Failed)

It looks like when these tests were added in #669 the CI was down, so I'm not confident these tests ever passed.

@EwanC
Copy link
Contributor

EwanC commented Jul 1, 2025 •
edited
Loading

@EwanC Do you have any idea why the GraphGemm tests are failing here?

The following tests FAILED:
	981 - BLAS/RT/GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________ (Failed)
	1965 - BLAS/CT/GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________ (Failed)

It looks like when these tests were added in #669 the CI was down, so I'm not confident these tests ever passed.

I changes I made when adding the tests focused on enabling the CUDA backend. I'd guess by the "AMD" part of the device name in the test string that these are running on a HIP SYCL backend. I can make similar changes to enable the tests for HIP, but in the short term to get the CI green I think we should disable the tests on AMD.

EwanC added a commit to EwanC/oneMath that referenced this pull request Jul 1, 2025
@EwanC
[BLAS] Skip sycl-graph tests on AMD
ce8cd35 
As reported in uxlfoundation#696 (comment)
the sycl-graph blas unit_tests are failing on AMD. Skip these tests
until the functionality can be implemented
@EwanC EwanC mentioned this pull request Jul 1, 2025
Merged
EwanC added a commit to EwanC/oneMath that referenced this pull request Jul 1, 2025
@EwanC
[BLAS] Skip sycl-graph tests on AMD
3c4279b 
As reported in uxlfoundation#696 (comment)
the sycl-graph blas unit_tests are failing on AMD. Skip these tests
until the functionality can be implemented
@dnhsieh-intel
Copy link
Contributor

dnhsieh-intel commented Jul 1, 2025 •
edited
Loading

@itopinsk Do you plan to update MKLConfig.cmake together in this PR or in another one? Please note that the license banner is different from the one in oneMKL package.

@dnhsieh-intel
Copy link
Contributor

Pushed update of MKLConfig.cmake per offline discussion. I am not sure what will happen for a PR not from a fork. I will duplicate it if we cannot merge it for some reasons.

@itopinsk itopinsk merged commit 5c7e1e7 into develop Jul 3, 2025
10 checks passed
@itopinsk itopinsk deleted the itopinsk-patch-1 branch July 3, 2025 08:27
@dnhsieh-intel dnhsieh-intel mentioned this pull request Jul 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtbarker andrewtbarker andrewtbarker approved these changes

@dnhsieh-intel dnhsieh-intel dnhsieh-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@itopinsk @andrewtbarker @EwanC @dnhsieh-intel