Skip to content

Update ubuntu CI image to 24.04 #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Jun 25, 2025

Description

  • Update ubuntu image in CI, Releases and Nightly Azure pipelines from 22.04 to 24.04
  • Unpin exact python version in pre-commit configuration to use default one available in the environment

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

N/A

Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge with a with a full description and with a green public CI

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 79.71% <ø> (?)
github 73.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alexsandruss
Copy link
Contributor Author

/azp run Release

Copy link

No pipelines are associated with this pull request.

@Alexsandruss
Copy link
Contributor Author

/azp run Releases

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Alexsandruss
Copy link
Contributor Author

/azp run Nightly

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Alexsandruss Alexsandruss added infra dependencies Pull requests that update a dependency file labels Jun 25, 2025
@Alexsandruss
Copy link
Contributor Author

Azure pipelines observations:

  • CI: one (sporadic?) test failed on both Linux and Win, so not related to this PR
  • Releases: same jobs failed on main branch
  • Nightly: same tests failed on main branch

@Alexsandruss Alexsandruss marked this pull request as ready for review June 25, 2025 17:34
@Alexsandruss
Copy link
Contributor Author

@icfaust, I removed python version req. from pre-commit config so it will be able to work for a default python installed in current CI or local env., let me know if you have any objection to that.

@Alexsandruss Alexsandruss merged commit 7585bf8 into uxlfoundation:main Jun 26, 2025
37 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants