Refactor GTM implementation to support google tag gateway #81011
+41
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the Google Tag Manager implementation on
@next/third-parties, it rewrites the implementation of the script url, params and types to allowgtmIdto be optional when a script URL is provided.Why?
Google released Google Tag Gateway for Advertisers which allows first-party tracking on GTM. When running GTM using the current implementation, it doesn't work because the
?id=is hardcoded into the implementation as it doesn't consider the possibility of tag gateway or any other setup where the ID is already part of the url.How?
Closes #81009