-
Notifications
You must be signed in to change notification settings - Fork 134
[Core-AAM] Update role=scrollbar AXAPI platform mappings #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rahim! A couple of things.
<p> | ||
<span class="property" | ||
>Property: <code>NSAccessibilityVerticalScrollBarAttribute</code>: pointer to accessible node matching IDREF of author-provided <code>aria-controls</code> for an element that | ||
represents a vertical scrollbar.</span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rahimabdi, with my read of the attribute's documentation... this property is not exposed scrollbar element, but on the element that the scroll bar controls? If so then these two properties don't belong here, because they aren't properties surfaced on the scrollbar.
Or maybe we could still say something about these properties here... something like:
If
aria-controls
is set on this the scrollbar element and references a valid element, and the scrollbar hasaria-orientation=vertical
, propertyNSAccessibilityVerticalScrollBarAttribute
should be exposed on the accessible node matching IDREF of author-providedaria-controls
. If the scrollbar hasaria-orientation=horizontal
, propertyNSAccessibilityHorizontalScrollBarAttribute
should be exposed on the accessible node matching IDREF of author-providedaria-controls
.
<sref>aria-expanded</sref> is also a <rref>treeitem</rref> in a <rref>tree</rref> or a <rref>row</rref> in a <rref>treegrid</rref>, then it SHOULD also be the | ||
<a>accessibility parent</a> of the content it expands and collapses. Otherwise, the element with <sref>aria-expanded</sref> SHOULD NOT be the <a>accessibility parent</a> of the content | ||
that is expanding or collapsing. Rather, identify that relationship between the interactive element and the element being controlled using <pref>aria-controls</pref>. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like formatting changes that snuck in because of prettier... :/ maybe try rebasing?
Closes w3c/core-aam#242
Update Core-AAM's role=scrollbar AXAPI mapping to use NSAccessibility scrollbar APIs where
aria-controls
is provided, e.g., https://developer.apple.com/documentation/appkit/nsaccessibility-swift.struct/attribute/verticalscrollbar?language=objc.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff