Skip to content

[pointer-animations-1] Prefix pointer() definition types #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jun 5, 2025

Type definitions share a common namespace and the <axis> type is already defined in Scroll-driven Animations:
https://drafts.csswg.org/scroll-animations-1/#typedef-axis

This update prefixes the <axis> type (and <source> for consistency) with pointer- to disambiguate. Feel free to adjust the name as you see fit!

Note: As in Scroll-driven Animations, the spec defines the types with a noexport attribute. That seems fine to avoid accidental references from other modules. If that is also meant to create a module-specific namespace for type definitions, we may have a problem as editing tools and validators that I'm aware of and that leverage CSS syntax definitions do not expect that to be possible ;)

Type definitions share a common namespace and the `<axis>` type is already
defined in Scroll-driven Animations:
https://drafts.csswg.org/scroll-animations-1/#typedef-axis

This update prefixes the `<axis>`, and `<source>` for consistency, types
with `pointer-` to disambiguate.
Copy link
Contributor

@ydaniv ydaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tidoust! If I recall correctly I meant to reuse axis from Scroll-driven Animations, but I'm ok with merging this as is for now, it's still an early ED.
The source is probably better off prefixed.

@tidoust
Copy link
Member Author

tidoust commented Jun 5, 2025

If I recall correctly I meant to reuse axis from Scroll-driven Animations

Up to you :) The noexport attribute of the <axis> definition would just need to be dropped in Scroll-driven Animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants