API for Reliable Resets #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also goes through and cleans up all the mess around RESET_STREAM. It's not perfect: we are now using that term (RESET_STREAM) to refer to a RESET_STREAM_AT frame (h3) or a WT_RESET_STREAM capsule (h2). Closes w3c#654.
jan-ivar
requested changes
Jun 30, 2025
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
|
I've added the committed offset to the abort algorithm as it should have had previously. The "Reset" operation that it invokes doesn't have a clean API, so I wasn't able to trace that any further though. Over to you. |
|
Note this will likely need a rebase as #669 is cleaning this up. But this should be enough to get |
|
Meeting:
|
|
Already done in c69ff24, merging. |
jan-ivar
approved these changes
Jul 1, 2025
github-actions bot
added a commit
that referenced
this pull request
Jul 1, 2025
SHA: 3e3629d Reason: push, by jan-ivar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also goes through and cleans up all the mess around RESET_STREAM. It's not perfect: we are now using that term (RESET_STREAM) to refer to a RESET_STREAM_AT frame (h3) or a WT_RESET_STREAM capsule (h2).
Closes #654.
Preview | Diff