Skip to content

Don't reject uploads with URLs as "empty" if the URL cannot be fetched #4043

Open
@gsnedders

Description

@gsnedders

c.f. #4020 (comment) in combination with:

p.download(results, screenshots, archives)
if len(p.results) == 0:
_log.error("No results successfully downloaded")
p.update_status(run_id, 'EMPTY', None, callback_url)
return ''

and:

artifact = self._download_http(archive_url)
if artifact is None:
return

and:

except requests.HTTPError:
_log.error("Failed to fetch (%d): %s", r.status_code, url)
return None

While it's technically true that the result set is empty, the fact that it's empty because we failed to download anything is distinctly different to actually receiving no results.

Metadata

Metadata

Assignees

No one assigned

    Labels

    back-endpythonPull requests that update Python code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions