Skip to content

Don't suffix Safari GH Actions artifacts when there's a single chunk #53008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gsnedders
Copy link
Member

This allows us to match the regexp that wpt.fyi uses to assign the
pr_base/pr_head labels.

This allows us to match the regexp that wpt.fyi uses to assign the
pr_base/pr_head labels.
@gsnedders
Copy link
Member Author

@gsnedders
Copy link
Member Author

https://staging.wpt.fyi/runs?max-count=100&pr=53008 shows everywhere else happily uploads an empty wrong, which suggests a wpt.fyi side problem.

@gsnedders gsnedders marked this pull request as draft June 7, 2025 23:54
@gsnedders gsnedders force-pushed the safari-no-suffix-artifact-names branch from f68deb5 to bdc79d9 Compare June 8, 2025 23:23
@gsnedders
Copy link
Member Author

https://staging.wpt.fyi/runs?max-count=100&pr=53008 shows everywhere else happily uploads an empty wrong, which suggests a wpt.fyi side problem.

But only insofar as we were filtering to safari-preview-affected-tests-without-changes-* which matched nothing.

The other job was matching on safari-preview-affected-tests-*, which safari-preview-affected-tests-without-changes does match.

This arguably shows some problem with the naming scheme insofar as the "with changes" artifact names always match the "without changes" ones.

@gsnedders
Copy link
Member Author

Lots of invalid runs showing on https://wpt.fyi/status, all things like:

Conflicting '/css/css-fonts/generic-family-keywords-001.html' found in the merged report

This is gonna be the same problem — it finds both when finding matching artifacts.

But when it expects artifacts whose names match specific globs, the only way to disambiguate these two will be to merge separate artifacts with @actions/upload-artifact/merge or similar.

This does actually allow us to avoid doing all this magic naming to avoid the suffix, because then we can just merge everything into something with the expected name.

@gsnedders
Copy link
Member Author

I split out the unrelated fix to #53024; closing this following the revert in #53016, and I'll simply re-land the whole thing (hopefully) working.

@gsnedders gsnedders closed this Jun 9, 2025
@gsnedders gsnedders deleted the safari-no-suffix-artifact-names branch June 9, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants