Tweak the WPT for lostpointercapture removing a pending capture node #53488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of Interop 2025. This CL changes the terminating condition for the test without affecting the test scenario that the second gotpointercapture is unexpected. The CL also corrects a misleading text in the test and mordernizes the JS a bit. We added a new test in the `bugs/` folder for the Blink-specific bug. Fixed: 404464586 Bug: 40942362 Change-Id: Ic54b7f1d9c19ee0a16492389b38657e32b2fd381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680949 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1480646}
wpt-pr-bot
approved these changes
Jun 30, 2025
|
@web-platform-tests/interop @aprotyas @masayuki-nakano Are you OK with this change to the Interop test? |
|
I don't think I'm ok with the changes. pointerevent_lostpointercapture_remove_setcapture_node.html is part of the interop-25, and now it has some blink/chrome specific hacks for some reason (there is even a comment about that). |
|
Ooop, sorry I didn't realize the workaround to make the test work for Blink affected other browsers! Late LGTM to the revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of Interop 2025.
This CL changes the terminating condition for the test without affecting
the test scenario that the second gotpointercapture is unexpected.
The CL also corrects a misleading text in the test and mordernizes the
JS a bit.
We added a new test in the
bugs/folder for the Blink-specific bug.Fixed: 404464586
Bug: 40942362
Change-Id: Ic54b7f1d9c19ee0a16492389b38657e32b2fd381
Change-Id: I90107ade1e2e9f367afc283515b1899354ef2444
Change-Id: I4f1d099a85695eeb5e3cfd46c2f460540391bddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680949
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1480646}