[animation-trigger] Parse timeline-trigger-name #53598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new plan for animation-trigger is that it will specify a dashed ident which identifies a trigger that is named by a timeline-trigger property whose timeline-trigger-name is a matching dashed ident. The parsing test is added to a new scroll-animations/animation-trigger/parsing as a way of keeping all animation-trigger related test as close as possible. Over the next couple of patches we will implement the following properties: - timeline-trigger-behavior, - timeline-trigger-range-start, - timeline-trigger-range-end, - timeline-trigger-exit-range, - timeline-trigger-exit-range-end - timeline-trigger (shorthand) Then, we will switch animation-trigger over to using dashed idents, delete the other animation-trigger-* properties, and then port all related tests to using timeline-trigger. Bug: 429392773, 390314945 Change-Id: I2dde943a1becfd24f3ff643b7fa4d2cc12fbbcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6702431 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: David Awogbemila <awogbemila@chromium.org> Cr-Commit-Position: refs/heads/main@{#1482671}
wpt-pr-bot
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new plan for animation-trigger is that it will specify a dashed
ident which identifies a trigger that is named by a timeline-trigger
property whose timeline-trigger-name is a matching dashed ident.
The parsing test is added to a new
scroll-animations/animation-trigger/parsing as a way of keeping all
animation-trigger related test as close as possible.
Over the next couple of patches we will implement the following
properties:
Then, we will switch animation-trigger over to using dashed idents,
delete the other animation-trigger-* properties, and then port all
related tests to using timeline-trigger.
Bug: 429392773, 390314945
Change-Id: I2dde943a1becfd24f3ff643b7fa4d2cc12fbbcde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6702431
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1482671}