-
Notifications
You must be signed in to change notification settings - Fork 659
Replace libprotobuf with upb for dynamic decode #7988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
Conversation
6d2a32e
to
965d05f
Compare
1b8ec22
to
a104e38
Compare
We're trying to minimize changes for 2026. Let's target this to 2027. |
I'll rebase this when #7983 gets merged into main and main gets merged into 2027. |
I merged main to 2027 but there's some fixes I need to make so it fully builds again. |
0172a65
to
c8371e7
Compare
I will note that |
1a7b031
to
650fa4c
Compare
libprotobuf is a very annoying dependency to deal with, and with the switch to nanopb for generated C++ code, libprotobuf is only used for dynamic decode in the GUI apps. libprotobuf has been swapped out with upb, a much smaller C-based library that supports reflection and can therefore do dynamic decode. This means we can remove the libprotobuf dependency and stop dealing with build issues because of it. Closes #6610 and closes #7250.