[ci] Add clang-cl workflow and fix clang-cl compilation #8007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: cscore
Gold856
force-pushed
the
clang-cl
branch
3 times, most recently
from
c3eedce to
ba75de3
Compare
github-actions
bot
removed
the
component: teamnumbersetter
|
I don't think we have been considering using clang-cl. It's not quite 100% ABI compatible with MSVC at the C++ level, so we wouldn't want to distribute binaries built with it unless we also switched all users to clang-cl as well (https://clang.llvm.org/docs/MSVCCompatibility.html). |
|
Yeah, I meant considering switching us and teams as well. Hypothetically, in the future, we could have some Bazel setup that uses clang-cl for C++ users so they have faster compile times, if we want to go down that path. I think it would be good to at least build for it in CI so that if we want to switch, we have the option to do so easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've been thinking about using clang-cl for Windows to improve compilation times, this PR adds a clang-cl workflow to ensure it builds.