go: remove deprecated features (bazel-contrib#2671)

* Remove go_rule.
* Remove go_archive_aspect and GoAspectProvider.
* Error when go_{binary,test} depends on go_{binary,test}.
* Ignore ctx.features and report warnings if they're used.

Author: Jay Conrod

extras/bindata.bzl

@@ -18,10 +18,6 @@ load(
     "@io_bazel_rules_go//go:def.bzl",
     "go_context",
 )
-load(
-    "@io_bazel_rules_go//go/private:rules/rule.bzl",
-    "go_rule",
-)
 
 def _bindata_impl(ctx):
     go = go_context(ctx)
@@ -62,8 +58,8 @@ def _bindata_impl(ctx):
         ),
     ]
 
-bindata = go_rule(
-    _bindata_impl,
+bindata = rule(
+    implementation = _bindata_impl,
     attrs = {
         "srcs": attr.label_list(allow_files = True),
         "package": attr.string(mandatory = True),
@@ -78,5 +74,9 @@ bindata = go_rule(
             cfg = "host",
             default = "@com_github_kevinburke_go_bindata//go-bindata:go-bindata",
         ),
+        "_go_context_data": attr.label(
+            default = "//:go_context_data",
+        ),
     },
+    toolchains = ["@io_bazel_rules_go//go:toolchain"],
 )

extras/embed_data.bzl

@@ -18,10 +18,6 @@ load(
     "@io_bazel_rules_go//go/private:context.bzl",  #TODO: This ought to be def
     "go_context",
 )
-load(
-    "@io_bazel_rules_go//go/private:rules/rule.bzl",
-    "go_rule",
-)
 
 def _go_embed_data_impl(ctx):
     go = go_context(ctx)
@@ -82,7 +78,7 @@ def _go_embed_data_impl(ctx):
         source,
     ]
 
-go_embed_data = go_rule(
+go_embed_data = rule(
     implementation = _go_embed_data_impl,
     attrs = {
         "package": attr.string(),
@@ -97,6 +93,10 @@ go_embed_data = go_rule(
             executable = True,
             cfg = "host",
         ),
+        "_go_context_data": attr.label(
+            default = "//:go_context_data",
+        ),
     },
+    toolchains = ["@io_bazel_rules_go//go:toolchain"],
 )
 # See go/extras.rst#go_embed_data for full documentation.

go/def.bzl

@@ -62,10 +62,6 @@ load(
     "@io_bazel_rules_go//go/private:tools/path.bzl",
     _go_path = "go_path",
 )
-load(
-    "@io_bazel_rules_go//go/private:rules/rule.bzl",
-    _go_rule = "go_rule",
-)
 load(
     "@io_bazel_rules_go//go/private:rules/library.bzl",
     _go_tool_library = "go_tool_library",
@@ -160,15 +156,15 @@ go_test = _go_test_macro
 # See go/core.rst#go_test for full documentation.
 go_source = _go_source
 
-# See go/core.rst#go_rule for full documentation.
-go_rule = _go_rule
-
 # See go/core.rst#go_path for full documentation.
 go_path = _go_path
 
 def go_vet_test(*args, **kwargs):
     fail("The go_vet_test rule has been removed. Please migrate to nogo instead, which supports vet tests.")
 
+def go_rule(**kwargs):
+    fail("The go_rule function has been removed. Use rule directly instead. See https://github.com/bazelbuild/rules_go/blob/master/go/toolchains.rst#writing-new-go-rules")
+
 def go_rules_dependencies():
     _moved("go_rules_dependencies")
 

go/private/context.bzl

@@ -276,17 +276,16 @@ def _collect_runfiles(go, data, deps):
 def _check_binary_dep(go, dep, edge):
     """Checks that this rule doesn't depend on a go_binary or go_test.
 
-    go_binary and go_test apply an aspect to their deps and embeds. If a
-    go_binary / go_test depends on another go_binary / go_test in different
-    modes, the aspect is applied twice, and Bazel emits an opaque error
-    message.
+    go_binary and go_test may return provides with useful information for other
+    rules (like go_path), but go_binary and go_test may not depend on other
+    go_binary and go_binary targets. Their dependencies may be built in
+    different modes, resulting in conflicts and opaque errors.
     """
     if (type(dep) == "Target" and
         DefaultInfo in dep and
         getattr(dep[DefaultInfo], "files_to_run", None) and
         dep[DefaultInfo].files_to_run.executable):
-        # TODO(#1735): make this an error after 0.16 is released.
-        print("WARNING: rule {rule} depends on executable {dep} via {edge}. This is not safe for cross-compilation. Depend on go_library instead. This will be an error in the future.".format(
+        fail("rule {rule} depends on executable {dep} via {edge}. This is not safe for cross-compilation. Depend on go_library instead.".format(
             rule = str(go._ctx.label),
             dep = str(dep.label),
             edge = edge,
@@ -496,6 +495,10 @@ def go_context(ctx, attr = None):
     )
 
 def _go_context_data_impl(ctx):
+    if "race" in ctx.features:
+        print("WARNING: --features=race is no longer supported. Use --@io_bazel_rules_go//go/config:race instead.")
+    if "msan" in ctx.features:
+        print("WARNING: --features=msan is no longer supported. Use --@io_bazel_rules_go//go/config:msan instead.")
     coverdata = ctx.attr.coverdata[GoArchive]
     nogo = ctx.files.nogo[0] if ctx.files.nogo else None
     providers = [

go/private/mode.bzl

@@ -65,22 +65,13 @@ def _ternary(*values):
     fail("_ternary failed to produce a final result from {}".format(values))
 
 def get_mode(ctx, go_toolchain, cgo_context_info, go_config_info):
-    static = _ternary(
-        "on" if "static" in ctx.features else "auto",
-        go_config_info.static if go_config_info else "off",
-    )
+    static = _ternary(go_config_info.static if go_config_info else "off")
     pure = _ternary(
         "on" if not cgo_context_info else "auto",
         go_config_info.pure if go_config_info else "off",
     )
-    race = _ternary(
-        "on" if ("race" in ctx.features and not pure) else "auto",
-        go_config_info.race if go_config_info else "off",
-    )
-    msan = _ternary(
-        "on" if ("msan" in ctx.features and not pure) else "auto",
-        go_config_info.msan if go_config_info else "off",
-    )
+    race = _ternary(go_config_info.race if go_config_info else "off")
+    msan = _ternary(go_config_info.msan if go_config_info else "off")
     strip = go_config_info.strip if go_config_info else False
     stamp = go_config_info.stamp if go_config_info else False
     debug = go_config_info.debug if go_config_info else False

go/private/providers.bzl

@@ -34,8 +34,6 @@ GoArchiveData = provider()
 # See go/providers.rst#GoArchive for full documentation.
 GoArchive = provider()
 
-GoAspectProviders = provider()
-
 GoPath = provider()
 
 GoSDK = provider(
@@ -76,15 +74,11 @@ EXPORT_PATH = "export"
 def get_source(dep):
     if type(dep) == "struct":
         return dep
-    if GoAspectProviders in dep:
-        return dep[GoAspectProviders].source
     return dep[GoSource]
 
 def get_archive(dep):
     if type(dep) == "struct":
         return dep
-    if GoAspectProviders in dep:
-        return dep[GoAspectProviders].archive
     return dep[GoArchive]
 
 def effective_importpath_pkgpath(lib):

go/private/rules/aspect.bzl

@@ -13,13 +13,9 @@
 # limitations under the License.
 
 load(
-    "@io_bazel_rules_go//go/private:context.bzl",
+    "//go/private:context.bzl",
     "go_context",
 )
-load(
-    "@io_bazel_rules_go//go/private:rules/rule.bzl",
-    "go_rule",
-)
 
 def _go_info_impl(ctx):
     go = go_context(ctx)
@@ -38,15 +34,19 @@ def _go_info_impl(ctx):
         runfiles = ctx.runfiles([report]),
     )]
 
-_go_info = go_rule(
-    _go_info_impl,
+_go_info = rule(
+    implementation = _go_info_impl,
     attrs = {
         "_go_info": attr.label(
             executable = True,
             cfg = "exec",
-            default = "@io_bazel_rules_go//go/tools/builders:info",
+            default = "//go/tools/builders:info",
+        ),
+        "_go_context_data": attr.label(
+            default = "//:go_context_data",
         ),
     },
+    toolchains = ["@io_bazel_rules_go//go:toolchain"],
 )
 
 def go_info():

go/private/rules/info.bzl

@@ -23,10 +23,6 @@ load(
     "GoProtoCompiler",
     "proto_path",
 )
-load(
-    "@io_bazel_rules_go//go/private:rules/rule.bzl",
-    "go_rule",
-)
 load(
     "@io_bazel_rules_go//go/private:providers.bzl",
     "INFERRED_PATH",
@@ -138,8 +134,8 @@ def _go_proto_library_impl(ctx):
         ])
     return providers + [OutputGroupInfo(**output_groups)]
 
-go_proto_library = go_rule(
-    _go_proto_library_impl,
+go_proto_library = rule(
+    implementation = _go_proto_library_impl,
     attrs = {
         "proto": attr.label(providers = [ProtoInfo]),
         "protos": attr.label_list(
@@ -160,7 +156,11 @@ go_proto_library = go_rule(
             providers = [GoProtoCompiler],
             default = ["@io_bazel_rules_go//proto:go_proto"],
         ),
+        "_go_context_data": attr.label(
+            default = "//:go_context_data",
+        ),
     },
+    toolchains = ["@io_bazel_rules_go//go:toolchain"],
 )
 # go_proto_library is a rule that takes a proto_library (in the proto
 # attribute) and produces a go library for it.