-
Notifications
You must be signed in to change notification settings - Fork 71
Socket Callback Optimizations #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 96.76% 97.79% +1.02%
==========================================
Files 3 3
Lines 557 545 -12
Branches 36 33 -3
==========================================
- Hits 539 533 -6
+ Misses 10 6 -4
+ Partials 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@webknjaz @Dreamsorcerer I just reverted those ignore blocks. |
Nvm, I forgot the loop will give us independent callbacks anyway. 👍 |
What do these changes do?
These changes are meant to speedup socket callbacks for the read and write file descriptors making the dns resolver run a bit smoother.
Are there changes in behavior for the user?
Removed some internal flags related to read and write but I don't think anybody is ever going to use them to begin with.
Related issue number
Checklist