Skip to content

llhttp submodule LICENSE not included in wheels? #11225

Open
@threexc

Description

@threexc

Describe the bug

As part of the RISE Project, I'm working on a build of aiohttp for riscv64. This is now working, but inspecting the resultant wheel shows that only aiohttp's LICENSE.txt file is packaged by default:

tgamblin@megalith ~/workspace/baylibre/rise/wheel_builder (tgamblin/aiohttp)$ unzip -l aiohttp-3.12.13-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | grep LICE
      588  06-14-2025 14:11   aiohttp-3.12.13.dist-info/licenses/LICENSE.txt

However, if llhttp is incorporated (and it seems to be, e.g. here, then shouldn't setup.cfg's license-files be a list that includes vendor/llhttp/LICENSE?

To Reproduce

  1. Pull recent aiohttp wheel
  2. unzip -l <aiohttp_wheel> and note occurrences of LICENSE files

Expected behavior

llhttp LICENSE file is included in the wheel

Logs/tracebacks

N/A

Python Version

Python 3.13.3 (Fedora 42), but seen for multiple versions

aiohttp Version

v3.11.18 (probably the case for most/all versions)

multidict Version

Name: multidict
Version: 6.4.4
Summary: multidict implementation
Home-page: https://github.com/aio-libs/multidict
Author: Andrew Svetlov
Author-email: andrew.svetlov@gmail.com
License: Apache 2
Location: /home/tgamblin/workspace/baylibre/rise/aiohttp/venv/lib64/python3.13/site-packages
Requires: 
Required-by: aiohttp, yarl

propcache Version

Name: propcache
Version: 0.3.1
Summary: Accelerated property cache
Home-page: https://github.com/aio-libs/propcache
Author: Andrew Svetlov
Author-email: andrew.svetlov@gmail.com
License: Apache-2.0
Location: /home/tgamblin/workspace/baylibre/rise/aiohttp/venv/lib64/python3.13/site-packages
Requires: 
Required-by: aiohttp, yarl

yarl Version

Name: yarl
Version: 1.20.0
Summary: Yet another URL library
Home-page: https://github.com/aio-libs/yarl
Author: Andrew Svetlov
Author-email: andrew.svetlov@gmail.com
License: Apache-2.0
Location: /home/tgamblin/workspace/baylibre/rise/aiohttp/venv/lib64/python3.13/site-packages
Requires: idna, multidict, propcache
Required-by: aiohttp

OS

Fedora 42

Related component

Client, Server

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions