Skip to content

Patchback/backports/3.13/4872fce3426119e63e1a892c39b474786dafddac/pr 11161 #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KGuillaume-chaps
Copy link
Contributor

What do these changes do?

Fixes for backporting pr #11161

paging @Dreamsorcerer

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 20, 2025
@KGuillaume-chaps KGuillaume-chaps changed the base branch from master to 3.13 June 20, 2025 07:20
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 84.72222% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.13@6aea2ce). Learn more about missing BASE report.

Files with missing lines Patch % Lines
aiohttp/compression_utils.py 63.15% 4 Missing and 3 partials ⚠️
aiohttp/http_parser.py 71.42% 1 Missing and 1 partial ⚠️
tests/test_http_parser.py 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             3.13   #11232   +/-   ##
=======================================
  Coverage        ?   98.28%           
=======================================
  Files           ?      132           
  Lines           ?    43565           
  Branches        ?     2387           
=======================================
  Hits            ?    42819           
  Misses          ?      565           
  Partials        ?      181           
Flag Coverage Δ
CI-GHA 98.18% <84.72%> (?)
OS-Linux 97.93% <84.72%> (?)
OS-Windows 95.64% <79.16%> (?)
OS-macOS 97.17% <79.16%> (?)
Py-3.10.11 96.81% <79.16%> (?)
Py-3.10.18 97.30% <79.16%> (?)
Py-3.11.13 97.50% <79.16%> (?)
Py-3.11.9 97.01% <79.16%> (?)
Py-3.12.10 97.10% <79.16%> (?)
Py-3.12.11 97.59% <79.16%> (?)
Py-3.13.3 97.83% <79.16%> (?)
Py-3.9.13 96.71% <79.16%> (?)
Py-3.9.23 97.18% <79.16%> (?)
Py-pypy7.3.16 88.05% <52.77%> (?)
VM-macos 97.17% <79.16%> (?)
VM-ubuntu 97.93% <84.72%> (?)
VM-windows 95.64% <79.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed Performance Report

Merging #11232 will not alter performance

Comparing KGuillaume-chaps:patchback/backports/3.13/4872fce3426119e63e1a892c39b474786dafddac/pr-11161 (db83889) with 3.13 (8e0b43c)

Summary

✅ 59 untouched benchmarks

@Dreamsorcerer Dreamsorcerer merged commit ff09341 into aio-libs:3.13 Jun 26, 2025
36 checks passed
@KGuillaume-chaps KGuillaume-chaps deleted the patchback/backports/3.13/4872fce3426119e63e1a892c39b474786dafddac/pr-11161 branch June 27, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants