-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[feat](param-refactor)Unify FS Factory Creation Logic and Support Broker Properties for Catalog Compatibility #51888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CalvinKirs
merged 3 commits into
apache:master
from
CalvinKirs:master-fs-factore-remote-fs
Jun 19, 2025
Merged
[feat](param-refactor)Unify FS Factory Creation Logic and Support Broker Properties for Catalog Compatibility #51888
CalvinKirs
merged 3 commits into
apache:master
from
CalvinKirs:master-fs-factore-remote-fs
Jun 19, 2025
+177
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker Properties for Catalog Compatibility
run buildall |
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 34150 ms
|
TPC-DS: Total hot run time: 193288 ms
|
ClickBench: Total hot run time: 28.8 s
|
run buildall |
TPC-H: Total hot run time: 33981 ms
|
TPC-DS: Total hot run time: 183647 ms
|
morningman
approved these changes
Jun 18, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 29.56 s
|
FE UT Coverage ReportIncrement line coverage |
hubgeter
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#50238
Eliminated Redundant bind.broker Usage in Catalog:
Previously, the Catalog used a custom bind.broker field—derived from the user-defined ↳broker.name—to determine whether to use a BrokerFileSystem, and to identify the specific broker.
Since we support many storage backends, keeping this value separately is redundant.
This PR migrates the logic into brokerProperties, allowing the factory to determine everything it needs from a single source of truth.
Refactored FSFactory Interface:
The original FSFactory contained too many scattered methods, making it harder to maintain and extend.
We've consolidated and organized its APIs for better clarity, reducing duplication and improving its usability across modules.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)