Skip to content

[Chore](nereids) Remove AlterSystemStmt #51890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

Conversation

xiedeyantu
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xiedeyantu
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33870 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d61e11752b44b9dbfbc20d86533c66f4c913b60, data reload: false

------ Round 1 ----------------------------------
q1	17620	5145	4974	4974
q2	1913	303	187	187
q3	10345	1316	698	698
q4	10281	1019	544	544
q5	8392	2427	2312	2312
q6	183	163	130	130
q7	919	746	614	614
q8	9316	1301	1105	1105
q9	6808	5087	5060	5060
q10	6890	2385	1953	1953
q11	484	289	283	283
q12	347	365	221	221
q13	17766	3709	3108	3108
q14	234	226	212	212
q15	575	468	476	468
q16	430	428	387	387
q17	590	849	359	359
q18	7655	7205	7243	7205
q19	1546	966	550	550
q20	323	330	222	222
q21	3990	3161	2331	2331
q22	1047	1023	947	947
Total cold run time: 107654 ms
Total hot run time: 33870 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5096	4997	5018	4997
q2	247	319	218	218
q3	2183	2656	2293	2293
q4	1377	1800	1378	1378
q5	4234	4135	4496	4135
q6	217	173	131	131
q7	2038	1936	1792	1792
q8	2604	2506	2481	2481
q9	7123	7175	7225	7175
q10	3078	3297	2811	2811
q11	573	515	487	487
q12	678	782	632	632
q13	3494	3916	3342	3342
q14	278	291	258	258
q15	523	490	462	462
q16	445	485	430	430
q17	1133	1568	1359	1359
q18	7645	7350	7570	7350
q19	783	825	873	825
q20	1986	2011	1877	1877
q21	4955	4357	4325	4325
q22	1070	1017	976	976
Total cold run time: 51760 ms
Total hot run time: 49734 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185776 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d61e11752b44b9dbfbc20d86533c66f4c913b60, data reload: false

query1	1001	396	394	394
query2	6524	1946	1917	1917
query3	6744	224	217	217
query4	26275	23315	23443	23315
query5	4357	620	483	483
query6	295	218	212	212
query7	4632	531	292	292
query8	286	243	219	219
query9	8626	2638	2662	2638
query10	484	362	287	287
query11	15576	15129	14793	14793
query12	163	111	105	105
query13	1659	527	407	407
query14	9464	6308	6144	6144
query15	202	190	166	166
query16	7331	608	480	480
query17	1171	720	561	561
query18	1970	417	316	316
query19	186	186	165	165
query20	120	118	117	117
query21	212	119	107	107
query22	4061	4038	3845	3845
query23	34117	33134	33119	33119
query24	8488	2418	2386	2386
query25	546	444	422	422
query26	1230	264	153	153
query27	2762	500	352	352
query28	4349	2134	2110	2110
query29	760	564	439	439
query30	275	222	191	191
query31	949	872	774	774
query32	77	66	67	66
query33	555	352	305	305
query34	794	835	550	550
query35	773	820	731	731
query36	960	951	884	884
query37	112	102	73	73
query38	4099	4174	4122	4122
query39	1459	1416	1406	1406
query40	215	117	108	108
query41	63	60	59	59
query42	128	113	112	112
query43	516	523	488	488
query44	1297	822	826	822
query45	182	174	169	169
query46	835	1022	625	625
query47	1746	1765	1716	1716
query48	385	423	310	310
query49	752	495	415	415
query50	625	669	412	412
query51	4159	4250	4043	4043
query52	111	108	105	105
query53	226	251	186	186
query54	569	573	505	505
query55	83	84	79	79
query56	304	298	310	298
query57	1173	1178	1130	1130
query58	268	260	251	251
query59	2753	2733	2632	2632
query60	324	318	293	293
query61	130	126	123	123
query62	804	715	665	665
query63	233	192	191	191
query64	4367	989	674	674
query65	4292	4194	4185	4185
query66	1134	426	319	319
query67	15811	15312	15188	15188
query68	4538	892	547	547
query69	471	301	279	279
query70	1182	1131	1130	1130
query71	388	321	317	317
query72	5558	4808	4649	4649
query73	648	587	356	356
query74	8916	9171	8660	8660
query75	3157	3226	2771	2771
query76	3233	1203	752	752
query77	482	372	297	297
query78	9986	10234	9402	9402
query79	1873	841	589	589
query80	675	503	469	469
query81	509	264	238	238
query82	393	129	99	99
query83	256	264	232	232
query84	265	110	96	96
query85	791	362	365	362
query86	307	293	305	293
query87	4474	4479	4372	4372
query88	2862	2261	2290	2261
query89	371	316	286	286
query90	1789	218	206	206
query91	143	138	113	113
query92	71	61	58	58
query93	1155	950	590	590
query94	645	399	309	309
query95	374	293	289	289
query96	484	564	276	276
query97	2721	2793	2610	2610
query98	239	207	199	199
query99	1340	1393	1303	1303
Total cold run time: 267425 ms
Total hot run time: 185776 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d61e11752b44b9dbfbc20d86533c66f4c913b60, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.25	0.06	0.07
query4	1.63	0.10	0.11
query5	0.42	0.42	0.44
query6	1.16	0.66	0.68
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.57	0.51	0.50
query10	0.57	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	0.80	0.82	0.84
query15	0.88	0.87	0.85
query16	0.40	0.38	0.40
query17	1.11	1.04	1.06
query18	0.23	0.21	0.22
query19	1.91	1.93	1.87
query20	0.02	0.01	0.01
query21	15.43	0.89	0.54
query22	0.77	1.11	0.65
query23	14.97	1.34	0.62
query24	6.37	0.93	0.77
query25	0.54	0.17	0.09
query26	0.57	0.16	0.15
query27	0.08	0.06	0.05
query28	10.01	0.91	0.44
query29	12.58	4.02	3.34
query30	0.26	0.09	0.06
query31	2.83	0.59	0.40
query32	3.24	0.55	0.48
query33	3.18	3.01	3.10
query34	16.09	5.39	4.76
query35	4.81	4.82	4.78
query36	0.68	0.51	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 103.95 s
Total hot run time: 29.41 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@xiedeyantu
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34159 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c08a3e3153162bf2b52e2f3d1d74a96645b5799c, data reload: false

------ Round 1 ----------------------------------
q1	17595	5217	5056	5056
q2	1927	281	188	188
q3	10328	1330	729	729
q4	10280	1004	540	540
q5	8141	2782	2352	2352
q6	189	161	131	131
q7	913	753	641	641
q8	9326	1298	1092	1092
q9	6757	5064	5101	5064
q10	6949	2371	1970	1970
q11	490	295	286	286
q12	345	360	229	229
q13	17779	3665	3120	3120
q14	241	232	218	218
q15	574	493	488	488
q16	441	439	375	375
q17	605	870	385	385
q18	7552	7132	7094	7094
q19	1963	982	581	581
q20	338	332	232	232
q21	3741	3255	2425	2425
q22	1056	1064	963	963
Total cold run time: 107530 ms
Total hot run time: 34159 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5285	5217	5109	5109
q2	244	321	233	233
q3	2163	2675	2281	2281
q4	1340	1808	1369	1369
q5	4251	4234	4378	4234
q6	210	166	131	131
q7	1990	1975	1806	1806
q8	2667	2556	2562	2556
q9	7134	7050	7131	7050
q10	3031	3316	2863	2863
q11	573	515	503	503
q12	675	774	639	639
q13	3513	3978	3296	3296
q14	292	307	279	279
q15	514	498	492	492
q16	437	470	439	439
q17	1153	1551	1382	1382
q18	7404	7166	7218	7166
q19	789	784	840	784
q20	1927	1966	1870	1870
q21	4783	4446	4303	4303
q22	1058	1035	967	967
Total cold run time: 51433 ms
Total hot run time: 49752 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186553 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c08a3e3153162bf2b52e2f3d1d74a96645b5799c, data reload: false

query1	1000	393	400	393
query2	6562	1829	1795	1795
query3	6747	237	219	219
query4	26570	23462	23778	23462
query5	4380	667	497	497
query6	332	257	208	208
query7	4624	513	296	296
query8	272	248	216	216
query9	8618	2618	2650	2618
query10	492	331	288	288
query11	15689	15170	14824	14824
query12	160	107	117	107
query13	1663	535	428	428
query14	9374	6280	6393	6280
query15	205	195	175	175
query16	7420	631	489	489
query17	1177	705	582	582
query18	1988	406	326	326
query19	201	195	160	160
query20	124	115	114	114
query21	215	128	111	111
query22	4161	4199	3996	3996
query23	34031	32909	33244	32909
query24	8496	2455	2413	2413
query25	528	463	416	416
query26	1228	273	157	157
query27	2751	532	357	357
query28	4289	2131	2111	2111
query29	741	579	451	451
query30	274	222	201	201
query31	937	869	726	726
query32	69	63	63	63
query33	564	366	308	308
query34	802	857	541	541
query35	772	838	750	750
query36	961	1012	882	882
query37	116	99	86	86
query38	4154	4239	4117	4117
query39	1482	1429	1424	1424
query40	204	122	115	115
query41	70	59	61	59
query42	128	113	109	109
query43	508	497	475	475
query44	1361	821	816	816
query45	183	188	177	177
query46	862	1053	651	651
query47	1766	1793	1731	1731
query48	390	442	324	324
query49	761	508	414	414
query50	657	704	413	413
query51	4197	4204	4074	4074
query52	108	105	98	98
query53	239	274	184	184
query54	591	590	528	528
query55	89	85	91	85
query56	321	307	315	307
query57	1155	1198	1128	1128
query58	277	269	282	269
query59	2605	2642	2519	2519
query60	374	349	334	334
query61	167	125	130	125
query62	781	735	676	676
query63	227	196	192	192
query64	4291	997	674	674
query65	4287	4224	4229	4224
query66	1127	417	322	322
query67	16013	15656	15357	15357
query68	8019	899	536	536
query69	491	317	280	280
query70	1175	1125	1081	1081
query71	461	321	296	296
query72	5772	4786	4768	4768
query73	711	630	357	357
query74	8887	9073	8725	8725
query75	3858	3237	2755	2755
query76	3715	1218	796	796
query77	808	381	287	287
query78	10138	10179	9400	9400
query79	2429	790	597	597
query80	620	513	457	457
query81	503	264	231	231
query82	477	130	104	104
query83	261	254	246	246
query84	251	105	101	101
query85	848	369	386	369
query86	392	306	296	296
query87	4446	4488	4339	4339
query88	3553	2317	2297	2297
query89	384	328	282	282
query90	1890	220	214	214
query91	142	145	115	115
query92	83	62	63	62
query93	1747	963	595	595
query94	677	413	311	311
query95	386	296	289	289
query96	498	576	289	289
query97	2733	2767	2729	2729
query98	235	219	205	205
query99	1348	1454	1268	1268
Total cold run time: 275846 ms
Total hot run time: 186553 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c08a3e3153162bf2b52e2f3d1d74a96645b5799c, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.44	0.44	0.43
query6	1.16	0.67	0.68
query7	0.03	0.01	0.02
query8	0.05	0.03	0.04
query9	0.57	0.53	0.50
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.65	0.62	0.62
query14	0.80	0.83	0.82
query15	0.91	0.86	0.90
query16	0.40	0.39	0.41
query17	1.14	1.09	1.06
query18	0.24	0.21	0.22
query19	2.03	1.88	1.90
query20	0.01	0.01	0.01
query21	15.41	0.91	0.54
query22	0.75	1.16	0.60
query23	15.05	1.36	0.63
query24	7.07	1.61	0.97
query25	0.52	0.17	0.20
query26	0.51	0.16	0.14
query27	0.07	0.06	0.05
query28	10.17	0.88	0.47
query29	12.54	3.96	3.37
query30	0.26	0.09	0.06
query31	2.83	0.62	0.41
query32	3.24	0.59	0.49
query33	3.08	3.14	3.07
query34	16.01	5.47	4.83
query35	4.88	4.87	4.86
query36	0.69	0.51	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.19	0.15	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.86 s
Total hot run time: 29.97 s

@xiedeyantu
Copy link
Member Author

run cloud_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 19, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starocean999 starocean999 merged commit d30a00a into apache:master Jun 19, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants