Skip to content

[chore](io) remove useless AsyncIO #51895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jun 18, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@w41ter
Copy link
Contributor Author

w41ter commented Jun 18, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jun 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter w41ter requested a review from yiguolei June 18, 2025 11:19
@doris-robot
Copy link

TPC-H: Total hot run time: 33981 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a5c5c04756449c7f7ccfc8546e68edebd08ae44, data reload: false

------ Round 1 ----------------------------------
q1	17647	5300	5031	5031
q2	1948	290	171	171
q3	10407	1286	782	782
q4	10215	1014	533	533
q5	7590	2401	2336	2336
q6	179	165	132	132
q7	911	740	606	606
q8	9319	1334	1101	1101
q9	6717	5098	5132	5098
q10	6898	2395	1967	1967
q11	489	288	293	288
q12	350	382	233	233
q13	17783	3724	3086	3086
q14	230	233	216	216
q15	557	476	483	476
q16	453	425	370	370
q17	603	869	353	353
q18	7575	7242	7025	7025
q19	1603	950	578	578
q20	331	345	219	219
q21	3750	3221	2405	2405
q22	1039	1013	975	975
Total cold run time: 106594 ms
Total hot run time: 33981 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5159	5084	5221	5084
q2	247	323	220	220
q3	2172	2671	2293	2293
q4	1388	1793	1386	1386
q5	4211	4130	4390	4130
q6	221	174	135	135
q7	2049	1910	1746	1746
q8	2642	2609	2586	2586
q9	7240	7137	7161	7137
q10	3093	3275	2748	2748
q11	570	503	479	479
q12	719	743	641	641
q13	3671	3878	3256	3256
q14	279	295	284	284
q15	544	486	468	468
q16	445	513	428	428
q17	1158	1588	1358	1358
q18	7832	7480	7399	7399
q19	875	860	880	860
q20	2020	2078	1910	1910
q21	5017	4523	4297	4297
q22	1021	1056	1015	1015
Total cold run time: 52573 ms
Total hot run time: 49860 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192956 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a5c5c04756449c7f7ccfc8546e68edebd08ae44, data reload: false

query1	1413	1035	987	987
query2	6276	1792	1844	1792
query3	11028	4547	4420	4420
query4	55812	25794	22981	22981
query5	5080	499	481	481
query6	343	222	202	202
query7	4877	519	293	293
query8	308	232	232	232
query9	5822	2627	2639	2627
query10	456	330	259	259
query11	14978	15083	14795	14795
query12	168	113	109	109
query13	1042	532	431	431
query14	10305	6556	6591	6556
query15	214	207	175	175
query16	7139	658	502	502
query17	1068	729	600	600
query18	1634	437	329	329
query19	200	203	178	178
query20	129	127	114	114
query21	209	129	112	112
query22	4373	4349	4352	4349
query23	34505	33516	33585	33516
query24	6543	2472	2481	2472
query25	501	520	432	432
query26	695	276	159	159
query27	2300	531	361	361
query28	3272	2177	2181	2177
query29	639	611	474	474
query30	283	232	200	200
query31	884	860	791	791
query32	77	69	69	69
query33	464	391	359	359
query34	809	888	539	539
query35	827	840	743	743
query36	931	1054	895	895
query37	119	115	88	88
query38	4216	4323	4214	4214
query39	1530	1489	1457	1457
query40	223	125	109	109
query41	68	61	64	61
query42	131	108	112	108
query43	519	532	487	487
query44	1417	866	840	840
query45	188	175	171	171
query46	962	1050	676	676
query47	1805	1850	1794	1794
query48	422	434	321	321
query49	671	481	447	447
query50	679	724	410	410
query51	4230	4318	4300	4300
query52	109	116	101	101
query53	241	268	191	191
query54	575	597	509	509
query55	88	81	86	81
query56	331	323	286	286
query57	1200	1218	1160	1160
query58	275	274	268	268
query59	2722	2842	2716	2716
query60	333	339	322	322
query61	128	137	124	124
query62	719	735	669	669
query63	225	186	188	186
query64	1626	1057	729	729
query65	4285	4211	4201	4201
query66	715	397	306	306
query67	16059	15554	15537	15537
query68	8057	852	517	517
query69	547	309	281	281
query70	1225	1123	1144	1123
query71	493	346	307	307
query72	5461	4819	4925	4819
query73	1458	672	355	355
query74	9359	9191	8708	8708
query75	3791	3189	2737	2737
query76	4146	1207	796	796
query77	609	385	289	289
query78	10166	10168	9291	9291
query79	5881	791	573	573
query80	641	528	445	445
query81	485	258	229	229
query82	684	135	100	100
query83	390	261	248	248
query84	295	105	84	84
query85	785	390	314	314
query86	418	305	292	292
query87	4499	4429	4327	4327
query88	3929	2279	2274	2274
query89	447	320	282	282
query90	1809	213	215	213
query91	138	143	108	108
query92	80	63	65	63
query93	3364	971	564	564
query94	669	415	289	289
query95	375	289	292	289
query96	497	595	279	279
query97	2760	2790	2665	2665
query98	230	205	214	205
query99	1427	1407	1310	1310
Total cold run time: 307530 ms
Total hot run time: 192956 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.44 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a5c5c04756449c7f7ccfc8546e68edebd08ae44, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.06
query4	1.60	0.10	0.10
query5	0.40	0.43	0.40
query6	1.18	0.66	0.67
query7	0.03	0.01	0.02
query8	0.04	0.04	0.04
query9	0.56	0.51	0.52
query10	0.57	0.58	0.58
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.64	0.61	0.61
query14	0.82	0.81	0.82
query15	0.88	0.87	0.88
query16	0.37	0.38	0.38
query17	1.05	1.08	1.05
query18	0.23	0.21	0.21
query19	2.01	1.91	1.88
query20	0.01	0.01	0.02
query21	15.39	0.89	0.52
query22	0.79	1.15	0.68
query23	14.93	1.40	0.61
query24	6.94	1.62	0.77
query25	0.47	0.15	0.08
query26	0.71	0.18	0.14
query27	0.07	0.06	0.05
query28	8.77	0.91	0.45
query29	12.56	3.97	3.31
query30	0.26	0.10	0.07
query31	2.81	0.62	0.40
query32	3.23	0.56	0.46
query33	3.01	3.09	3.15
query34	16.17	5.34	4.77
query35	4.82	4.83	4.79
query36	0.69	0.49	0.51
query37	0.09	0.07	0.06
query38	0.06	0.03	0.03
query39	0.03	0.03	0.02
query40	0.19	0.14	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 103.18 s
Total hot run time: 29.44 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants