Skip to content

[chore](http) return NOT_FOUND if dir is not exists #51897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jun 18, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring added dev/2.1.x dev/3.0.x usercase Important user case type label labels Jun 18, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 18, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@w41ter
Copy link
Contributor Author

w41ter commented Jun 18, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33742 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ad67ad168e68bdf0cb13fbc6e3171bdf526877a, data reload: false

------ Round 1 ----------------------------------
q1	17690	5163	4986	4986
q2	1933	295	194	194
q3	10299	1306	693	693
q4	10213	1027	518	518
q5	7485	2424	2320	2320
q6	172	159	128	128
q7	910	754	606	606
q8	9326	1277	1055	1055
q9	6828	5094	5030	5030
q10	6887	2382	1961	1961
q11	483	294	280	280
q12	344	349	215	215
q13	17750	3644	3101	3101
q14	238	225	227	225
q15	548	478	487	478
q16	432	433	374	374
q17	584	856	353	353
q18	7702	7161	7225	7161
q19	1099	944	563	563
q20	336	331	228	228
q21	3778	2563	2307	2307
q22	1067	1038	966	966
Total cold run time: 106104 ms
Total hot run time: 33742 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5048	5107	4995	4995
q2	238	330	229	229
q3	2188	2649	2273	2273
q4	1335	1801	1356	1356
q5	4229	4148	4389	4148
q6	218	173	127	127
q7	2017	1927	1784	1784
q8	2609	2544	2554	2544
q9	7168	7110	7067	7067
q10	3047	3261	2864	2864
q11	594	517	489	489
q12	692	769	581	581
q13	3508	3839	3274	3274
q14	300	297	300	297
q15	519	478	461	461
q16	451	492	462	462
q17	1146	1552	1365	1365
q18	7726	7535	7355	7355
q19	803	808	896	808
q20	1962	1997	1888	1888
q21	4935	4491	4420	4420
q22	1085	1028	989	989
Total cold run time: 51818 ms
Total hot run time: 49776 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184856 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ad67ad168e68bdf0cb13fbc6e3171bdf526877a, data reload: false

query1	1019	411	387	387
query2	6540	1783	1802	1783
query3	6736	226	222	222
query4	27094	23774	22898	22898
query5	4366	635	441	441
query6	304	211	200	200
query7	4632	490	284	284
query8	288	227	225	225
query9	8618	2633	2636	2633
query10	472	340	284	284
query11	15820	15046	14767	14767
query12	169	112	110	110
query13	1671	520	415	415
query14	9414	6127	6107	6107
query15	201	193	164	164
query16	7316	608	451	451
query17	1200	722	592	592
query18	2012	417	310	310
query19	195	190	167	167
query20	178	119	115	115
query21	216	127	106	106
query22	4039	4136	3973	3973
query23	34033	33057	33140	33057
query24	8445	2388	2396	2388
query25	533	459	380	380
query26	1229	262	149	149
query27	2769	504	345	345
query28	4361	2132	2114	2114
query29	767	561	430	430
query30	277	225	185	185
query31	954	862	760	760
query32	74	60	69	60
query33	551	382	309	309
query34	792	840	535	535
query35	776	791	740	740
query36	930	974	893	893
query37	106	101	74	74
query38	4106	4136	4042	4042
query39	1474	1478	1433	1433
query40	211	120	105	105
query41	69	58	57	57
query42	126	112	110	110
query43	489	496	471	471
query44	1298	809	808	808
query45	173	171	166	166
query46	840	1031	629	629
query47	1747	1803	1729	1729
query48	389	415	307	307
query49	741	480	407	407
query50	635	671	415	415
query51	4201	4121	4166	4121
query52	112	107	103	103
query53	228	258	181	181
query54	565	590	502	502
query55	81	82	86	82
query56	297	290	288	288
query57	1178	1198	1119	1119
query58	269	264	250	250
query59	2570	2645	2573	2573
query60	315	343	309	309
query61	125	118	120	118
query62	793	705	632	632
query63	226	183	185	183
query64	4361	989	696	696
query65	4267	4138	4221	4138
query66	1138	420	302	302
query67	15845	15574	15217	15217
query68	8110	889	516	516
query69	471	301	272	272
query70	1168	1151	1087	1087
query71	520	328	290	290
query72	5614	4772	4835	4772
query73	683	626	351	351
query74	9065	9104	8697	8697
query75	3906	3181	2689	2689
query76	3699	1196	758	758
query77	767	381	293	293
query78	10076	10109	9397	9397
query79	2568	821	595	595
query80	649	509	438	438
query81	507	258	214	214
query82	450	128	100	100
query83	286	248	238	238
query84	295	109	87	87
query85	792	360	312	312
query86	395	302	284	284
query87	4357	4447	4336	4336
query88	3767	2288	2260	2260
query89	384	305	287	287
query90	1892	206	201	201
query91	141	161	117	117
query92	82	65	62	62
query93	2066	935	583	583
query94	668	398	311	311
query95	368	297	289	289
query96	492	572	282	282
query97	2747	2777	2684	2684
query98	230	246	204	204
query99	1464	1379	1304	1304
Total cold run time: 276645 ms
Total hot run time: 184856 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1ad67ad168e68bdf0cb13fbc6e3171bdf526877a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.41	0.43	0.40
query6	1.15	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.52	0.51
query10	0.58	0.58	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.63	0.61	0.61
query14	0.81	0.84	0.81
query15	0.89	0.86	0.88
query16	0.38	0.38	0.38
query17	1.09	1.03	1.04
query18	0.23	0.21	0.22
query19	1.97	1.83	1.92
query20	0.02	0.01	0.01
query21	15.40	0.93	0.55
query22	0.75	1.20	0.98
query23	14.69	1.39	0.59
query24	7.43	0.83	0.93
query25	0.47	0.18	0.15
query26	0.65	0.17	0.13
query27	0.06	0.05	0.05
query28	9.17	0.92	0.47
query29	12.54	4.06	3.36
query30	0.25	0.09	0.06
query31	2.82	0.62	0.39
query32	3.25	0.56	0.47
query33	3.02	3.06	3.14
query34	16.07	5.40	4.76
query35	4.78	4.85	4.79
query36	0.68	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.19	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.59 s
Total hot run time: 29.83 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.34% (15049/26709)
Line Coverage 45.10% (134596/298408)
Region Coverage 44.24% (67702/153021)
Branch Coverage 38.82% (34728/89466)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 60.89% (16004/26284)
Line Coverage 50.32% (150092/298247)
Region Coverage 47.66% (85797/180003)
Branch Coverage 41.20% (42134/102276)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants