-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[chore](cloud) Implement idempotent injection framework for meta-service #51905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gavinchou
wants to merge
1
commit into
apache:master
Choose a base branch
from
gavinchou:gavin-ms-idempotent-framework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This commit support to inject idempotent requests by replaying request with random delay the following configs are added ``` CONF_mBool(enable_idempotent_request_injection, "false"); // idempotent_request_replay_delay_ms = idempotent_request_replay_delay_base_ms + random(-idempotent_request_replay_delay_range_ms, idempotent_request_replay_delay_range_ms) CONF_mInt64(idempotent_request_replay_delay_base_ms, "10000"); CONF_mInt64(idempotent_request_replay_delay_range_ms, "5000"); // exclude some request that are meaningless to replay, comma separated list. e.g. GetTabletStatsRequest,GetVersionRequest CONF_mString(idempotent_request_replay_exclusion, "GetTabletStatsRequest,GetVersionRequest"); ``` to enable request replay ``` enable_idempotent_request_injection=true ``` to set random delay in a range [idempotent_request_replay_delay_base_ms - idempotent_request_replay_delay_range_ms, idempotent_request_replay_delay_base_ms + idempotent_request_replay_delay_range_ms] the following example means the request will be replayed with a delay ranges from 5000ms to 15000ms ``` idempotent_request_replay_delay_base_ms=10000 idempotent_request_replay_delay_range_ms=5000 ``` if the randomly chosen delay is negative the request will be not replayed (idempotent_request_replay_delay_range_ms can be set greater than idempotent_request_replay_delay_base_ms) to exclude some requests (PB message names), the following examples means GetTabletStatsRequest and GetVersionRequest will not be replayed ``` idempotent_request_replay_exclusion=GetTabletStatsRequest,GetVersionRequest ```
7eb9d70
to
2960b0c
Compare
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
w41ter
approved these changes
Jun 19, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit support to inject idempotent requests by replaying request with random delay
the following configs are added
to enable request replay
to set random delay in a range
[idempotent_request_replay_delay_base_ms - idempotent_request_replay_delay_range_ms, idempotent_request_replay_delay_base_ms + idempotent_request_replay_delay_range_ms] the following example means the request will be replayed with a delay ranges from 5000ms to 15000ms
if the randomly chosen delay is negative the request will be not replayed (idempotent_request_replay_delay_range_ms can be set greater than idempotent_request_replay_delay_base_ms)
to exclude some requests (PB message names), the following examples means GetTabletStatsRequest and GetVersionRequest will not be replayed