-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[hotfix] Rename isUnalignedCheckpointsInterruptibleTimersEnabled config #26666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey, you need to rebase since we had an issue on master |
.getOptional(CheckpointingOptions.ENABLE_UNALIGNED_INTERRUPTIBLE_TIMERS) | ||
.ifPresent(this::enableUnalignedCheckpointsInterruptibleTimers); | ||
.getOptional(CheckpointingOptions.ENABLE_UNALIGNED_SPLITTABLE_TIMERS) | ||
.ifPresent(this::enableUnalignedCheckpointsSplitttableTimers); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: enableUnalignedCheckpointsSplitttableTimers has 3 ts here - typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha yes, I dont want to introduce another typo while trying to fix a typo
@@ -576,8 +576,8 @@ public class CheckpointingOptions { | |||
.build()); | |||
|
|||
@Experimental | |||
public static final ConfigOption<Boolean> ENABLE_UNALIGNED_INTERRUPTIBLE_TIMERS = | |||
ConfigOptions.key("execution.checkpointing.unaligned.interruptible-timers.enabled") | |||
public static final ConfigOption<Boolean> ENABLE_UNALIGNED_SPLITTABLE_TIMERS = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume existing configs will break - if they were using the old values. I know it is experimental - but can we help the user here. Maybe if they use the old value then they should get an error.
I only see execution.checkpointing.unaligned.interruptible-timers.enabled
defined once in master - why do you think this is a cut and paste error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an internal fork of Flink and I noticed that we only used the splittable config instead of the interruptible config. I figured that maybe something went wrong when @pnowojski open sourced this feature. Piotr can you confirm whether we should be using splittable
or interruptible
here, because right now they are intermixed like on this line https://github.com/apache/flink/pull/26666/files#diff-35fa4795524db4fca98cd404f3184bf9ec2a903d673f49074a1ab970733aa0eaL1261-L1262
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of renaming the config execution.checkpointing.unaligned.interruptible-timers.enabled
, a smaller change would be to replace the use of splittable
with interruptible
, like on the line above.
@@ -113,9 +113,8 @@ private static Stream<TestSpec<?>> specs() { | |||
.whenSetFromFile( | |||
"execution.checkpointing.unaligned.interruptible-timers.enabled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops needs to update this too
Seems to be a copy paste typo, this PR correctly specifies the appropriate config flag
isUnalignedCheckpointsSplittableTimersEnabled
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation