[FLINK-37969] Allow Transformation subgraphs to be merged during translation #26699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
approved these changes
Jun 18, 2025
| TypeInformation<T> typeInformation, | ||
| Predicate<Transformation<?>> upstreamFinder, | ||
| Function<Transformation<?>, Transformation<?>> inputAdjuster) { | ||
| checkNotNull(upstreamFinder, "connectionId must not be null"); |
There was a problem hiding this comment.
Suggested change
| checkNotNull(upstreamFinder, "connectionId must not be null"); | |
| checkNotNull(upstreamFinder, "upstreamFinder must not be null"); |
…slation Transformations are immutable by design and thus planner or DataStream API need to generate a subgraph in one pass. However, there are some use cases where we would attach some small subgraph to a larger subgraph before translation into a StreamGraph. For example, system views in SQL may actually refer to specific parts of the query where we would like to add a subgraph to a side-output. This commit adds StubTransformation that is later connected to an existing Transformation by defining a predicate to find the upstream transformations to which to connect the downstream transformations.
AHeise
force-pushed
the
flink-37969-stub-transformation
branch
from
d5491d6 to
7e7847b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Transformations are immutable by design and thus planner or DataStream API need to generate a subgraph in one pass. However, there are some use cases where we would attach some small subgraph to a larger subgraph before translation into a StreamGraph. For example, system views in SQL may actually refer to specific parts of the query where we would like to add a subgraph to a side-output.
This commit adds StubTransformation that is later connected to an existing Transformation by defining a predicate to find the upstream transformations to which to connect the downstream transformations.
Brief change log
Verifying this change
Added unit tests in StreamGraphGeneratorTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation