[GSOC] Add sse mcp server #3503
Open
+685
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the mcp a bean and run as the process as original spring boot
Removed previous LLM service implementations and introduced a unified ChatClientProviderService to handle interactions with LLM providers. Implemented ConversationService enhancements with new capabilities like streaming responses, conversation history, and management. Updated configurations and dependencies to support these changes.
Removed unused imports, methods, and annotations to streamline the codebase and improve maintainability. Updated `pom.xml` to add necessary dependencies and repositories for AI functionality. Refactored controllers to include standard REST mappings for improved API structure.
- MCP server - working - Chat Client - working - Client able to access the tools - working - dependencies resolved
Removed `AgentApplication` configuration class, shifting `ToolCallbackProvider` setup to `McpServerServiceImpl`. Refactored `ChatClientProviderService` to unify chat handling logic and added support for streaming chat responses via `ChatController`. These changes improve modularity and simplify chat-related operations.
Removed unused MCP configuration classes and updated method and bean names to replace "monitorTools" with "hertzbeatTools" for better clarity and consistency. This improves code readability and aligns naming with project conventions.
Renamed and updated methods for better clarity and functionality, such as `listMonitors` replacing `getMonitors`. Introduced `PromptProvider` to standardize AI prompts for monitoring operations. Enhanced error handling and logging for the `MonitorServiceAdapterImpl` to improve debugging and reliability.
github-project-automation
bot
added this to
Apache HertzBeat (Incubating) and hertzbeat-v1.0
tomsun28
reviewed
Jun 27, 2025
Comment on lines
-50
to
-54
|
|
||
| @PostConstruct | ||
| public void init() { | ||
| System.setProperty("jdk.jndi.object.factoriesFilter", "!com.zaxxer.hikari.HikariJNDIFactory"); | ||
| } |
There was a problem hiding this comment.
hi please not delete these code, if anyelse reason to delete them?
tomsun28
reviewed
Jun 27, 2025
| } | ||
|
|
||
| assert monitorService != null; | ||
| System.out.println("MonitorServiceImpl found: " + Arrays.toString(monitorService.getClass().getMethods())); |
There was a problem hiding this comment.
please use log to instead of System.out.println
tomsun28
reviewed
Jun 27, 2025
Comment on lines
+39
to
+50
| public SseEmitter streamChat(@RequestBody ChatRequestContext context) { | ||
| SseEmitter emitter = new SseEmitter(); | ||
| new Thread(() -> { | ||
| try { | ||
| String aiResponse = chatClientProviderService.streamChat(context); | ||
| emitter.send(aiResponse); | ||
| emitter.complete(); | ||
| } catch (Exception e) { | ||
| emitter.completeWithError(e); | ||
| } | ||
| }).start(); | ||
| return emitter; |
There was a problem hiding this comment.
how about use the webflux and reactor likeFlux<ServerSentEvent<XX>>
There was a problem hiding this comment.
|
hi please add the apache license header and fix backend ci. |
yuluo-yx
reviewed
Jul 2, 2025
| </plugins> | ||
| </build> | ||
|
|
||
| </project> |
There was a problem hiding this comment.
All files in the project should end with a blank line.
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
yuluo-yx
reviewed
Jul 2, 2025
| public class LlmConfig { | ||
| @Bean | ||
| public ChatClient openAiChatClient(OpenAiChatModel chatModel) { | ||
| return ChatClient.create(chatModel); |
There was a problem hiding this comment.
Is the create method used directly here to create the ChatClient instance? Do we need some other parameters?
yuluo-yx
reviewed
Jul 2, 2025
| * Static version of the HertzBeat monitoring prompt | ||
| */ | ||
| public static final String HERTZBEAT_MONITORING_PROMPT = | ||
| "You are an AI assistant specialized in monitoring infrastructure and applications with HertzBeat. " |
There was a problem hiding this comment.
IMO, we can use java17 string blocks to write promotion, which is more readable.
such as:
String content = """
prompt content
"""；
yuluo-yx
reviewed
Jul 2, 2025
| private final ChatClientProviderService chatClientProviderService; | ||
|
|
||
| @Autowired | ||
| public ChatController(@Qualifier("openAiChatClient") ChatClient openAiChatClient, |
There was a problem hiding this comment.
I saw that only openai starter was referenced in the project. So I don't think it is necessary to use it here @Qualifier("openAiChatClient". Unless we have plans to introduce other models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API