AWS: Add support to run all integration tests when S3 Analytics Accelerator is enabled #13347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator is enabled
SanjayMarreddi
force-pushed
the
integration_tests_with_analytics_accelerator_library
branch
from
66983fe to
3db8540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have integrated analytics-accelerator-s3 into Iceberg in PR #12299. Currently, Iceberg customers need to enable the
s3.analytics-accelerator.enabledflag inS3FileIOPropertiesto use the library. We plan to make this feature enabled by default in the future and have begun addressing the feature gaps between our current Analytics Accelerator Library (AAL) stream and the existingS3InputStream. This PR marks the beginning of our work toward default integration.Description of PR
This PR modifies the existing integration tests to ensure compatibility when AAL is enabled by default. It incorporates all necessary async client setup code and skips integration tests that would currently fail if AAL is enabled in local setups. These skipped tests represent the feature gaps we are actively working to resolve.
Testing
All integration tests function properly with AAL disabled (current default behavior) and also work when AAL is enabled (with the exception of a few skipped tests).