[core] fix that batch CompactAction makes no sense with all level-0 files #5790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
If the table is dv enabled or using first-row as merge engine, and its writing job is write-only, compact action in batch mode for this table will generate 0 splits. This is because
DataTableBatchScanwill skip all level-0 files when dv enabled or with first-row merge engine while files written with write-only set to true are all in level-0.This pr introduced a new option "batch-scan-mode" which should only be used internally, if
batch-scan-mode = compact, thescanwon't apply the level-0 filter.Tests
CompactActionITCase#testCompactWhenSkipLevel0
API and Format
Documentation