Skip to content

[core] Fix stats filter by pushdown after schema evolution #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Jul 1, 2025

Purpose

Reproduce steps:

CREATE TABLE T (a STRING);
INSERT INTO T VALUES ('9'), ('10'), ('11');
ALTER TABLE T MODIFY (a INT);
SELECT * FROM T WHERE a > 9; -- return empty but expected (10), (11)

The reason is stats type has been modified (similar to #4705 ).

Tests

Note:
SchemaEvolutionTest#testAddField for nullSafe arg.

API and Format

Documentation

@yuzelin yuzelin force-pushed the fix-stats-filter branch from 67a6f86 to 33677bd Compare July 1, 2025 12:32
@yuzelin yuzelin changed the title [core] Fix stats filter by pushdown after schema evolution (#4705) [core] Fix stats filter by pushdown after schema evolution Jul 1, 2025
@yuzelin
Copy link
Contributor Author

yuzelin commented Jul 1, 2025

@JingsongLi can we delete SchemaEvolutionTableTestBase and related tests? It depends on filter evolution even the type is changed a lot but this commit forbid this behavior.

@yuzelin yuzelin force-pushed the fix-stats-filter branch from 33677bd to b3ca28a Compare July 2, 2025 02:20
@yuzelin
Copy link
Contributor Author

yuzelin commented Jul 2, 2025

SchemaEvolutionTableTestBase and related tests are removed.

yuzelin added 2 commits July 2, 2025 10:24
@yuzelin yuzelin force-pushed the fix-stats-filter branch from 4655d8a to 6e8bea3 Compare July 2, 2025 03:28
@JingsongLi
Copy link
Contributor

SchemaEvolutionTableTestBase and related tests are removed.

now which tests can cover the cases here?

@yuzelin
Copy link
Contributor Author

yuzelin commented Jul 4, 2025

SchemaEvolutionTableTestBase and related tests are removed.

now which tests can cover the cases here?

I will check all the tests and find tests that can be kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants