fix: ensure isFinishedFunction is re-evaluated after state restore [#2917] #3017
+33
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How goes this PR close the issue in question (#2917)? Also, this removes the unlock call in BasicCrawler, same as your other PR. Is that intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug where isFinishedFunction was not evaluated after restoring from persistent state, causing the crawler to continue running even if the crawl had logically completed. This addresses the unexpected behavior reported in #2917.
Changes Introduced
Added an explicit check for isFinishedFunction immediately after this._init() in the run() method. If the function returns true, the crawler logs a message and exits early. This preserves consistent shutdown logic whether the crawl is resumed or started fresh.
Related Information
Fixes: #2917
This change improves correctness during host migration or restarts by preventing unnecessary crawling when the task is already complete.