Clarifiy error message when using an improperly formatted secret with kube

[Craig-Spencer-12]

Using an improperly formatted secret with kube returns a generic error message
Error: failed to create volume "my-volume": error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type v1.Secret

This PR updates the error message to include why the failure occured:
Error: failed to create volume "my-volume": only secrets created via the kube yaml file are supported: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type v1.Secret

Closes: #26561

Does this PR introduce a user-facing change?

Clarified error message when using an improperly formatted secret with kube

[Craig-Spencer-12]

Failing because this PR doesn't add any tests. I don't think this PR requires a new test since its just tweaking an existing error message.

Let me know if I'm wrong and I'll whip up a test.

[Luap99]

A test case would be good to just to make sure we keep it working and this is indeed the right place. You could have a look at "secret as volume support - simple" in test/e2e/play_kube_test.go and then instead add a case where you created the secret with podman secret create and make sure it errors with the proper message.

Also FYI please add Fixes: #26561 as part of the commit message itself not just in the PR description.
https://github.com/containers/podman/blob/main/CONTRIBUTING.md#describe-your-changes-in-commit-messages

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[Craig-Spencer-12]

I copied the test secret as volume support - simple but the test is a bit long since I couldn't reuse all the functions used in that test.

• createAndTestSecret - creates its secret with kube play so I had to tweak that
• testPodWithSecret - I couldn't find a way to assert its output from outside the function and I didn't want to change the function itself
• deleteAndTestSecret - reusable

I could definitely slim the test down a bit but I'm curious what you guys think.

[Craig-Spencer-12]

Also a spent a long time trying to solve a bug on my end where podman didn't recognize crun. Turns out I had an old version installed that was messing things up so I reinstalled it from source manually.

Not sure if this is a common issue but I figured I'd mention it somewhere since it blocked me for a while. But lessons learned and now my debugging and testing setup is running smoothly!

[mheon]

Restarted 3 flakes.

[mheon]

DCO check is complaining about one of your commits, though.

[mheon]

One nit, code LGTM

[Luap99]

Thanks, please squash all commits into one as we merge commit as is and there should be no wip commits and the likes. And we prefer chnage and test to be part of the same commit.

There seem to be some weird merge commits in here. Our general workflow is to rebase PRs again main to keep it up to date with the latest changes.

[Luap99]

/lgtm

Thank you

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Craig-Spencer-12, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment