[Bug]: After setting the oco hook, the cancellation behavior of git commit.

[PhantasWeng]

Opencommit Version

3.2.9

Node Version

22.15.1

NPM Version

11.4.1

What OS are you seeing the problem on?

No response

What happened?

After setting up oco hook set, when I use git commit, it enters the vim editor, which is normal so far.

However, once I use :q! to cancel the edit, a normal git commit would cancel the commit action, but after oco hook set, oco still commits the message I canceled.

Expected Behavior

oco should only commit when I finish with :wq, and if I use :q! to cancel editing, it should cancel the entire action.

Current Behavior

Whether it's :wq or :q!, both will commit the message.

Possible Solution

When using oco normally, it will ask Confirm the commit message? ○ Yes / ● No and then Do you want to regenerate the message? ○ Yes / ● No. The cancel action of :q! should be equivalent to No + No.

Steps to Reproduce

No response

Relevant log output

[doitian]

Use :cq to exit vim

[PhantasWeng]

Use :cq to exit vim

Thank you for providing the tutorial. this is a workable method.

However, it differs from the original judgment of git cm. Since it is a hook function, when exiting, if the information is not saved, it should also be judged as abandoned, consistent with the original git cm.

[di-sukharev]

this needs a patch to how hook works, do you want to make a contribution @PhantasWeng?

[PhantasWeng]

Alright, I’m not very familiar with it, but I can look into it and see how to proceed.

[PhantasWeng]

After I tried to modify it, I found that git does not allow us to determine how we exited the editor.

If we compare it to the normal behavior of git commit, it might be better to place the generated message as a comment.

The process is as follows.

1. When writing the msg generated by AI into COMMIT_EDITMSG, add a # prefix in front.
2. When the user opens the editor, what they see is in a commented-out state.

The user can uncomment it themselves or leave it blank.

User's Action	Msg	Result
User doesn't uncomment	blan	cancel
User does uncomment	msg	committed
User does uncomment + :q!	blank	cancel
User does uncomment + :cq	cancel edit	cancel

@di-sukharev What do you think? If you think it's feasible, I will continue.

[di-sukharev]

@PhantasWeng sounds smart, what do you think about adding one more comment above saying "uncomment the line below for git to see the generated commit message. If you don't want to commit this message leave it as is and just exit this window"?

[PhantasWeng]

Of course! This is exactly what I want to do.
I’ll take care of it—wait for my PR.

[di-sukharev]

💪