Skip to content

feat: add no-invalid-named-grid-areas rule #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xbinaryx
Copy link

@xbinaryx xbinaryx commented Jun 9, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR adds a new rule no-invalid-named-grid-areas to enforce valid named grid area definitions in CSS Grid templates. The rule helps prevent common mistakes when using grid-template-areas and related properties by checking that named grid areas are properly defined according to the CSS Grid specification.

What changes did you make? (Give an overview)

Added the no-invalid-named-grid-areas rule, along with documentation and tests.

Related Issues

Fixes #158

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 9, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 10, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jun 10, 2025
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage Jun 10, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Would like another review before merging.

@nzakas nzakas moved this from Needs Triage to Second Review Needed in Triage Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature
Projects
Status: Second Review Needed
Development

Successfully merging this pull request may close these issues.

New Rule: no-invalid-named-grid-areas
3 participants