feat: add no-invalid-at-rule-placement rule #171
Conversation
lumirlumir
added
the
accepted
| # no-invalid-at-rule-placement | ||
|
|
||
| Disallow invalid placement of at-rules. | ||
|
|
||
| ## Background | ||
|
|
||
| At-rules are CSS statements that instruct CSS how to behave. Some at-rules have strict placement requirements that must be followed for the stylesheet to work correctly. For example: |
There was a problem hiding this comment.
@charset is no longer considered an at-rule even though it syntactically looks like one. There may be a more suitable name and wording in the documentation that better reflect this.
There was a problem hiding this comment.
If it's not an at-rule, then what is it? The spec is ridiculously worded:
https://drafts.csswg.org/css-syntax/#charset-rule
There was a problem hiding this comment.
According to MDN, it's not technically an at-rule but a specific byte sequence. However, I noticed it's referred to as an at-rule in no-invalid-at-rules as well. Should we add a clarifying note about this, or leave it as-is for now?
There was a problem hiding this comment.
Let's leave this as-is for now. We can always circle back and do doc updates later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request introduces a new rule no-invalid-at-rule-placement that enforces correct placement of at-rules within stylesheets.
What changes did you make? (Give an overview)
Implemented the no-invalid-at-rule-placement rule, along with documentation and tests.
Related Issues
Fixes #163
Fixes #151
Is there anything you'd like reviewers to focus on?