You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I ran make verify, I noticed that the verify_go_versions.sh script didn't print any message indicating success.
Of course, by reading the script, it's clear that the absence of any error messages implies success. Still, I thought it might be helpful if the script explicitly printed a success message.
So, I’d like to suggest adding the following line to the end of scripts/verify_go_versions.sh:
+ log_success "SUCCESS"
By adding this line, the output will look like this:
expected go toolchain directive: go1.24.4
SUCCESS # added by this change
I’d appreciate it if you could consider this suggestion.
If this change is acceptable, I’d be happy to submit a PR to implement it myself.
Thank you for your time, and I apologize if this suggestion is out of place.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
When I ran
make verify
, I noticed that theverify_go_versions.sh
script didn't print any message indicating success.Of course, by reading the script, it's clear that the absence of any error messages implies success. Still, I thought it might be helpful if the script explicitly printed a success message.
So, I’d like to suggest adding the following line to the end of
scripts/verify_go_versions.sh:
+ log_success "SUCCESS"
By adding this line, the output will look like this:
expected go toolchain directive: go1.24.4 SUCCESS # added by this change
I’d appreciate it if you could consider this suggestion.
If this change is acceptable, I’d be happy to submit a PR to implement it myself.
Thank you for your time, and I apologize if this suggestion is out of place.
Beta Was this translation helpful? Give feedback.
All reactions