Skip to content

make verify-lint fails on devcontainer #20199

Open
@BBQing

Description

@BBQing

Bug report criteria

What happened?

make verify-lint fails on devcontainer development environment

What did you expect to happen?

it shouldn' fail

How can we reproduce it (as minimally and precisely as possible)?

open workspace in newly built devcontainer and run make verify-lint

Anything else we need to know?

the problem is that make install-golangci-lint is not enforcing version of golangci-lint (it uses 2.1.6 installed during the creation of devcontainer instead of version from tool/mod/go.mod file

Etcd version (please run commands below)

$ etcd --version
vscode ➜ /workspaces/etcd (main) $ ./bin/etcd --version
etcd Version: 3.7.0-alpha.0
Git SHA: c68e3f427
Go Version: go1.24.3
Go OS/Arch: linux/amd64

$ etcdctl version
vscode ➜ /workspaces/etcd (main) $ ./bin/etcdctl version
etcdctl version: 3.7.0-alpha.0
API version: 3.7

Etcd configuration (command line flags or environment variables)

paste your configuration here

Etcd debug information (please run commands below, feel free to obfuscate the IP address or FQDN in the output)

$ etcdctl member list -w table
# paste output here

$ etcdctl --endpoints=<member list> endpoint status -w table
# paste output here

Relevant log output

`vscode ➜ /workspaces/etcd (main) $ make verify-lint
PASSES="lint" ./scripts/test.sh
Running with --race
Starting at: Sat Jun 21 12:41:14 AM UTC 2025

'lint' started at Sat Jun 21 12:41:14 AM UTC 2025
% (cd api && 'golangci-lint' 'run' '--config' '/workspaces/etcd/tools/.golangci.yaml' './...')
stderr: Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/product/migration-guide for migration instructions
stderr: Failed executing command with error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/product/migration-guide for migration instructions
FAIL: (code:3):
  % (cd api && 'golangci-lint' 'run' '--config' '/workspaces/etcd/tools/.golangci.yaml' './...')

FAIL: 'run golangci-lint run --config /workspaces/etcd/tools/.golangci.yaml ./...' checking failed (!=0 return code)
There was a Failure in module api, aborting...
FAIL: 'lint' FAILED at Sat Jun 21 12:41:14 AM UTC 2025
make: *** [Makefile:112: verify-lint] Error 255`

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions