Skip to content

[release-3.5] Add makefile target for run-govuluncheck #20172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abdurrehman107
Copy link
Member

This PR adds run-govuluncheck makefile target for release-3.5.

ref: kubernetes/test-infra#32754 (comment)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Signed-off-by: Abdur Rehman <razashahid107@gmail.com>
@ivanvc
Copy link
Member

ivanvc commented Jun 13, 2025

/cc @ivanvc

@k8s-ci-robot k8s-ci-robot requested a review from ivanvc June 13, 2025 19:08
@ivanvc
Copy link
Member

ivanvc commented Jun 13, 2025

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @abdurrehman107

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jmhbnz.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdurrehman107, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 75357ec into etcd-io:release-3.5 Jun 16, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants