Skip to content

Refactor and add connect all client #20173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

nwnt
Copy link
Member

@nwnt nwnt commented Jun 14, 2025

Fix #20052

This also contains quite extensive refactoring for simulateTraffic.

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.74%. Comparing base (fb7e3f2) to head (500642c).
Report is 5 commits behind head on main.

Additional details and impacted files

see 157 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20173      +/-   ##
==========================================
- Coverage   69.09%   62.74%   -6.35%     
==========================================
  Files         410      401       -9     
  Lines       34232    33295     -937     
==========================================
- Hits        23653    20892    -2761     
- Misses       9165    10851    +1686     
- Partials     1414     1552     +138     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7e3f2...500642c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt nwnt force-pushed the nwnt/add-client-connecting-all branch from 1b96db6 to 25df6f8 Compare June 24, 2025 02:44
@nwnt nwnt force-pushed the nwnt/add-client-connecting-all branch from 25df6f8 to 2fed9a8 Compare June 24, 2025 02:48
Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the nwnt/add-client-connecting-all branch from 2fed9a8 to 500642c Compare June 24, 2025 12:50
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit c6804c8 into etcd-io:main Jun 24, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Antithesis+Robustness] Add a client that connects to all members
3 participants