Skip to content

CHANGELOG(3.4,3.5): Add Go 1.23.10 note #20174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025

Conversation

hwdef
Copy link
Contributor

@hwdef hwdef commented Jun 14, 2025

Part of: #20126

@hwdef
Copy link
Contributor Author

hwdef commented Jun 14, 2025

/cc @ivanvc

@k8s-ci-robot
Copy link

Hi @hwdef. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jun 15, 2025

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @hwdef. Please review my comment :)

@@ -12,7 +12,7 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/

### Dependencies

- Compile binaries using [go 1.23.9](https://github.com/etcd-io/etcd/pull/19872).
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20164).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is the one from 3.4. It should be #20166.

Suggested change
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20164).
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20166).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this. I've fixed it

@ivanvc ivanvc mentioned this pull request Jun 15, 2025
19 tasks
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (cc29bc0) to head (d61b803).
Report is 16 commits behind head on main.

Additional details and impacted files

see 32 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20174      +/-   ##
==========================================
- Coverage   69.27%   68.69%   -0.58%     
==========================================
  Files         413      413              
  Lines       34364    34364              
==========================================
- Hits        23805    23608     -197     
- Misses       9160     9356     +196     
- Partials     1399     1400       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37ff81...d61b803. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: hwdef <hwdefcom@outlook.com>
@hwdef hwdef force-pushed the changelog-35-36-go12310 branch from c7e3363 to d61b803 Compare June 15, 2025 09:19
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, hwdef, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c68e3f4 into etcd-io:main Jun 15, 2025
33 checks passed
@hwdef hwdef deleted the changelog-35-36-go12310 branch June 16, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants