-
Notifications
You must be signed in to change notification settings - Fork 10.1k
CHANGELOG(3.4,3.5): Add Go 1.23.10 note #20174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @ivanvc |
Hi @hwdef. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, @hwdef. Please review my comment :)
CHANGELOG/CHANGELOG-3.4.md
Outdated
@@ -12,7 +12,7 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
|
|||
### Dependencies | |||
|
|||
- Compile binaries using [go 1.23.9](https://github.com/etcd-io/etcd/pull/19872). | |||
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20164). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is the one from 3.4. It should be #20166.
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20164). | |
- Compile binaries using [go 1.23.10](https://github.com/etcd-io/etcd/pull/20166). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this. I've fixed it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 32 files with indirect coverage changes @@ Coverage Diff @@
## main #20174 +/- ##
==========================================
- Coverage 69.27% 68.69% -0.58%
==========================================
Files 413 413
Lines 34364 34364
==========================================
- Hits 23805 23608 -197
- Misses 9160 9356 +196
- Partials 1399 1400 +1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: hwdef <hwdefcom@outlook.com>
c7e3363
to
d61b803
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, hwdef, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of: #20126